Fixed bug 4538 - validate image size when loading BMP files

libsdl-org · Jul 30, 2019 · e12c931 · e12c931
1 parent cdb178b
commit e12c931
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/IMG_bmp.c b/IMG_bmp.c
@@ -272,6 +272,11 @@ static SDL_Surface *LoadBMP_RW (SDL_RWops *src, int freesrc)
 		biClrUsed	= SDL_ReadLE32(src);
 		biClrImportant	= SDL_ReadLE32(src);
 	}
+	if (biWidth <= 0 || biHeight == 0) {
+		IMG_SetError("BMP file with bad dimensions (%dx%d)", biWidth, biHeight);
+		was_error = SDL_TRUE;
+		goto done;
+	}
 	if (biHeight < 0) {
 		topDown = SDL_TRUE;
 		biHeight = -biHeight;