xpm, xv: minor warning fixes (SDL_RWread() doesn't return negative)

libsdl-org · Sep 11, 2019 · 020a29a · 020a29a
1 parent fdcf483
commit 020a29a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/IMG_xpm.c b/IMG_xpm.c
@@ -934,7 +934,7 @@ static char *get_next_line(char ***lines, SDL_RWops *src, int len)
         char c;
         int n;
         do {
-            if (SDL_RWread(src, &c, 1, 1) <= 0) {
+            if (!SDL_RWread(src, &c, 1, 1)) {
                 error = "Premature end of data";
                 return NULL;
             }
@@ -951,7 +951,7 @@ static char *get_next_line(char ***lines, SDL_RWops *src, int len)
                 }
                 linebuf = linebufnew;
             }
-            if (SDL_RWread(src, linebuf, len - 1, 1) <= 0) {
+            if (!SDL_RWread(src, linebuf, len - 1, 1)) {
                 error = "Premature end of data";
                 return NULL;
             }
@@ -971,7 +971,7 @@ static char *get_next_line(char ***lines, SDL_RWops *src, int len)
                     }
                     linebuf = linebufnew;
                 }
-                if (SDL_RWread(src, linebuf + n, 1, 1) <= 0) {
+                if (!SDL_RWread(src, linebuf + n, 1, 1)) {
                     error = "Premature end of data";
                     return NULL;
                 }

diff --git a/IMG_xv.c b/IMG_xv.c
@@ -28,7 +28,7 @@
 static int get_line(SDL_RWops *src, char *line, int size)
 {
     while ( size > 0 ) {
-        if ( SDL_RWread(src, line, 1, 1) <= 0 ) {
+        if ( !SDL_RWread(src, line, 1, 1) ) {
             return -1;
         }
         if ( *line == '\r' ) {
@@ -126,7 +126,7 @@ SDL_Surface *IMG_LoadXV_RW(SDL_RWops *src)
 
     /* Load the image data */
     for ( pixels = (Uint8 *)surface->pixels; h > 0; --h ) {
-        if ( SDL_RWread(src, pixels, w, 1) <= 0 ) {
+        if ( !SDL_RWread(src, pixels, w, 1) ) {
             error = "Couldn't read image data";
             goto done;
         }