Fixed bug #766

Mason Wheeler 2009-07-06 14:29:47 PDT This adds some missing error reporting for SDL_SelectRenderer, and cleans up the logic a little bit.
libsdl-org · Sep 26, 2009 · ccb47ce · ccb47ce
1 parent 62610da
commit ccb47ce
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/src/video/SDL_video.c b/src/video/SDL_video.c
@@ -1501,11 +1501,16 @@ SDL_SelectRenderer(SDL_WindowID windowID)
     SDL_Window *window = SDL_GetWindowFromID(windowID);
     SDL_Renderer *renderer;
 
-    if (!window || !window->renderer) {
+    if (!window) {
+        SDL_SetError("Invalid window ID");
         return -1;
     }
     renderer = window->renderer;
-    if (renderer && renderer->ActivateRenderer) {
+    if (!renderer) {
+        SDL_SetError("Renderer hasn't been created yet");
+        return -1;
+    }
+    if (renderer->ActivateRenderer) {
         if (renderer->ActivateRenderer(renderer) < 0) {
             return -1;
         }