ate: Fri, 09 Apr 2004 20:07:10 +0200
authorSam Lantinga
Sun, 16 May 2004 18:02:48 +0000
changeset 889eac8c69b5706
parent 888 07def9d03315
child 890 416158ec61a0
ate: Fri, 09 Apr 2004 20:07:10 +0200
From: Hibernatus
Subject: [SDL] BUG: changing video mode in opengl + windows

In WIN_GL_SetupWindow (SDL12/src/video/wincommon/SDL_wingl.c) you call
WIN_GL_ResetWindow when SetPixelFormat fails.
WIN_GL_ResetWindow cannot properly work in its current state, because there
are several things to update once you've created a new window. At least
DirectInput doesn't work anymore here (which is somewhat annoying for the
player :).
I think you can simply remove that function. Many games don't try to
recover from that exception, that's why the newest ATI drivers emulate 16
bpp display in 32 bpp mode so the error never occurs (but the games may run
much slower).

Having SDL_SetVideoMode return NULL would be better than actually setting
the video mode and losing focus, directinput and maybe directsound too. It
also made my previous drivers crash (when switching from 32 bpp windowed to
16 bpp fullscreen).
src/video/wincommon/SDL_wingl.c
     1.1 --- a/src/video/wincommon/SDL_wingl.c	Sun May 16 17:40:32 2004 +0000
     1.2 +++ b/src/video/wincommon/SDL_wingl.c	Sun May 16 18:02:48 2004 +0000
     1.3 @@ -50,6 +50,7 @@
     1.4  	if ( SDL_windowid ) {
     1.5  		can_reset = 0;
     1.6  	}
     1.7 +#if 0 /* This doesn't work with DirectX code (see CVS comments) */
     1.8  #ifndef _WIN32_WCE /* FIXME WinCE needs the UNICODE version of CreateWindow() */
     1.9  	if ( can_reset ) {
    1.10  		/* Save the existing window attributes */
    1.11 @@ -72,6 +73,7 @@
    1.12  		}
    1.13  	} else
    1.14  #endif /* !_WIN32_WCE */
    1.15 +#endif
    1.16  	{
    1.17  		SDL_SetError("Unable to reset window for OpenGL context");
    1.18  		status = -1;