Skip to content

Commit

Permalink
Date: Sun, 2 Jan 2005 18:36:09 +0100
Browse files Browse the repository at this point in the history
From: Jon Daniel
Subject: [SDL] KeyRepeat fix

If you switch keys very fast and hold the last one it
doesn't get repeated because the key release of the first key
occured after the key press of the second key.
Unfortunatly the key release of the first key sets
SDL_KeyRepeat.timestamp = 0; causing the the second key not to repeat.

This should be always reproducable. I've only checked this on x86-64
X11.

To fix this I just added another condition to make sure the sym of the
released key matches SDL_KeyRepeat.key.keysym.sym.
  • Loading branch information
slouken committed Jan 3, 2005
1 parent 29b2f98 commit 540fb26
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/events/SDL_keyboard.c
Expand Up @@ -491,7 +491,8 @@ printf("The '%s' key has been %s\n", SDL_GetKeyName(keysym->sym),
/*
* jk 991215 - Added
*/
if ( SDL_KeyRepeat.timestamp ) {
if ( SDL_KeyRepeat.timestamp &&
SDL_KeyRepeat.evt.key.keysym.sym == keysym->sym ) {
SDL_KeyRepeat.timestamp = 0;
}
break;
Expand Down

0 comments on commit 540fb26

Please sign in to comment.