Date: Tue, 5 Oct 2004 11:04:02 -0400
authorSam Lantinga
Fri, 12 Nov 2004 21:29:52 +0000
changeset 967cda407d627a3
parent 966 f72cc0c7305f
child 968 4675910b0b7b
Date: Tue, 5 Oct 2004 11:04:02 -0400
From: Bob Ippolito
Subject: [SDL] PATCH: Fix for release count bug in SDL_QuartzWM

SDL_QuartzWM incorrectly does [window close]; [window release];

The semantics for -[NSWindow close] are as follows:

Removes the receiver from the screen. If the receiver is set to be
released when closed, a release message is sent to the object after the
current event is completed. For an NSWindow object, the default is to
be released on closing, while for an NSPanel object, the default is not
to be released. You can use the setReleasedWhenClosed: method to change
the default behavior.

This patch simply removes the incorrect release.
src/video/quartz/SDL_QuartzVideo.m
     1.1 --- a/src/video/quartz/SDL_QuartzVideo.m	Fri Nov 12 21:25:42 2004 +0000
     1.2 +++ b/src/video/quartz/SDL_QuartzVideo.m	Fri Nov 12 21:29:52 2004 +0000
     1.3 @@ -485,7 +485,6 @@
     1.4      else {
     1.5          
     1.6          [ qz_window close ];
     1.7 -        [ qz_window release ];
     1.8          qz_window = nil;
     1.9          window_view = nil;
    1.10