Hi Sam

In X11_CreateYUVOverlay hwdata->image will be accessed after it has been freed, causing undefined behavior. Exchanging two lines as shown in this patch will fix that problem: Regards, Bodo
libsdl-org · Dec 2, 2011 · b6f1e27 · b6f1e27
1 parent 5d19ed6
commit b6f1e27
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/video/x11/SDL_x11yuv.c b/src/video/x11/SDL_x11yuv.c
@@ -330,8 +330,8 @@ SDL_Overlay *X11_CreateYUVOverlay(_THIS, int width, int height, Uint32 format, S
 #ifdef PITCH_WORKAROUND
 	if ( hwdata->image != NULL && hwdata->image->pitches[0] != (width*bpp) ) {
 		/* Ajust overlay width according to pitch */ 
-		XFree(hwdata->image);
 		width = hwdata->image->pitches[0] / bpp;
+		XFree(hwdata->image);
 		hwdata->image = SDL_NAME(XvShmCreateImage)(GFX_Display, xv_port, format,
 							   0, width, height, yuvshm);
 	}