/* FIXME FIXME FIXME

* Window creation fails in the colormap code on DirectColor visuals: * XA_RGB_BEST_MAP not found and could not be created * I'm disabling this for now until Bob can look at it. We don't need * it until we implement the gamma fading using DirectColor RGB ramps */
libsdl-org · Dec 22, 2008 · 78cc73d · 78cc73d
1 parent 81d7903
commit 78cc73d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/TODO b/TODO
@@ -5,7 +5,8 @@
    - in progress, software support is done, Ryan is working on OpenGL shaders
  * Implement desktop video mode change notification?
  * Implement icon support (with translucency?)
- * Add draw blend mode and line drawing support for software renderer and win32
+ * Add draw blend mode and line drawing support for win32
+ * Have Bob look at why DirectColor visuals fail with XA_RGB_BEST_MAP error
  * Verify mouse grab support
  * Properly handle mouse grab with Vista DPI scaling
  * Make sure the mouse is where it's supposed to be when un-grabbed

diff --git a/src/video/x11/SDL_x11modes.c b/src/video/x11/SDL_x11modes.c
@@ -32,7 +32,13 @@ static int
 get_visualinfo(Display * display, int screen, XVisualInfo * vinfo)
 {
     const char *visual_id = SDL_getenv("SDL_VIDEO_X11_VISUALID");
-    int use_directcolor = 1;
+    /* FIXME FIXME FIXME
+     * Window creation fails in the colormap code on DirectColor visuals:
+     *      XA_RGB_BEST_MAP not found and could not be created
+     * I'm disabling this for now until Bob can look at it.  We don't need
+     * it until we implement the gamma fading using DirectColor RGB ramps
+     */
+    int use_directcolor = 0;
     int depth;
 
     /* Look for an exact visual, if requested */