Daniel Wyatt 2010-03-26 14:52:53 PDT
authorSam Lantinga
Mon, 12 Jul 2010 22:08:50 -0700
changeset 4511ae7799d16c87
parent 4510 6f8175ad0335
child 4512 ba9ac6bb0c75
Daniel Wyatt 2010-03-26 14:52:53 PDT

If a non-console Windows SDL program has a non-quoted 0th argument followed
optionally by more non-quoted arguments and then by an empty quoted argument,
it will crash (attempts to dereference a NULL pointer).

In other words, something like this:
test.exe [non-quoted args] "" [...]

The fix is a one-liner in ParseCommandLine() of
src/main/win32/SDL_win32_main.c.

You can test this with any non-console SDL program on windows like this:
1) Open a console (cmd.exe)
2) Launch the program in one of the following ways:
program ""
program arg1 ""
program arg1 "" arg3

These will not cause a crash:
"program" [...]
program "arg1" ""

When a Windows program is launched from Explorer, its 0th argument seems to
always be quoted, so it won't be a problem in that case.

I've tested this on Windows XP SP3 and Windows 7.
src/main/win32/SDL_win32_main.c
     1.1 --- a/src/main/win32/SDL_win32_main.c	Mon Jul 12 01:20:57 2010 -0700
     1.2 +++ b/src/main/win32/SDL_win32_main.c	Mon Jul 12 22:08:50 2010 -0700
     1.3 @@ -71,6 +71,7 @@
     1.4                  ++argc;
     1.5              }
     1.6              /* Skip over word */
     1.7 +            lastp = bufp;
     1.8              while (*bufp && (*bufp != '"' || *lastp == '\\')) {
     1.9                  lastp = bufp;
    1.10                  ++bufp;