Date: Sun, 3 Aug 2003 22:07:57 +0200
authorSam Lantinga <slouken@libsdl.org>
Mon, 04 Aug 2003 01:00:30 +0000
changeset 664abfdc08eb289
parent 663 8bedd6d61642
child 665 d27aab66c5d6
Date: Sun, 3 Aug 2003 22:07:57 +0200
From: Max Horn
Subject: SDL OSX fullscreen FIX

the attached patch fixes the fullscreen problems on SDL/OSX. The cause
was that click events are bounded by winRect. Now, winRect is set to
the size of the video surface. But if you e.g. request a 640x420
surface, you might get a 640x480 "real" surface. Still,
SDL_VideoSurface->h will be set to 420! Thus, the upper 60 pixels in my
example received no mouse down events.

My fix simply disables this clipping when in full screen mode - after
all, all clicks then should be inside the screen surface. Higher SDL
functions ensure that the coordinates then are clipped to 640x420. It
works fine in all my tests here. I don't know if it's the right thing
to do in multi screen scenarios, though.
src/video/quartz/SDL_QuartzEvents.m
     1.1 --- a/src/video/quartz/SDL_QuartzEvents.m	Mon Aug 04 00:52:42 2003 +0000
     1.2 +++ b/src/video/quartz/SDL_QuartzEvents.m	Mon Aug 04 01:00:30 2003 +0000
     1.3 @@ -255,13 +255,13 @@
     1.4  
     1.5  static void QZ_DoModifiers (_THIS, unsigned int newMods) {
     1.6  
     1.7 -    const int mapping[] = { SDLK_CAPSLOCK, SDLK_LSHIFT, SDLK_LCTRL, SDLK_LALT, SDLK_LMETA } ;
     1.8 +    const int mapping[] = { SDLK_CAPSLOCK, SDLK_LSHIFT, SDLK_LCTRL, SDLK_LALT, SDLK_LMETA };
     1.9  
    1.10      int i;
    1.11      int bit;
    1.12      SDL_keysym key;
    1.13  
    1.14 -    key.scancode = 0;
    1.15 +    key.scancode    = 0;
    1.16      key.sym         = SDLK_UNKNOWN;
    1.17      key.unicode     = 0;
    1.18      key.mod         = KMOD_NONE;
    1.19 @@ -405,7 +405,6 @@
    1.20      NSDate *distantPast;
    1.21      NSEvent *event;
    1.22      NSRect winRect;
    1.23 -    NSRect titleBarRect;
    1.24      NSAutoreleasePool *pool;
    1.25  
    1.26      /* Update activity every five seconds to prevent screensaver. --ryan. */
    1.27 @@ -421,8 +420,6 @@
    1.28      distantPast = [ NSDate distantPast ];
    1.29  
    1.30      winRect = NSMakeRect (0, 0, SDL_VideoSurface->w, SDL_VideoSurface->h);
    1.31 -    titleBarRect = NSMakeRect (0, SDL_VideoSurface->h, SDL_VideoSurface->w,
    1.32 -                                SDL_VideoSurface->h + 22);
    1.33      
    1.34      /* send the first mouse event in absolute coordinates */
    1.35      firstMouseEvent = 1;
    1.36 @@ -467,7 +464,7 @@
    1.37              
    1.38              type = [ event type ];
    1.39              isForGameWin = (qz_window == [ event window ]);
    1.40 -            isInGameWin = NSPointInRect([event locationInWindow], winRect);
    1.41 +            isInGameWin = (mode_flags & SDL_FULLSCREEN) ? true : NSPointInRect([event locationInWindow], winRect);
    1.42              switch (type) {
    1.43                  case NSLeftMouseDown:
    1.44                      if ( getenv("SDL_HAS3BUTTONMOUSE") ) {