tap should default to disabled, not enabled

libsdl-org · Nov 26, 2016 · 25f54f0 · 25f54f0
1 parent 354a8f2
commit 25f54f0
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/video/cocoa/SDL_cocoamousetap.m b/src/video/cocoa/SDL_cocoamousetap.m
@@ -203,6 +203,8 @@
                                         kCGEventTapOptionDefault, allGrabbedEventsMask,
                                         &Cocoa_MouseTapCallback, tapdata);
         if (tapdata->tap) {
+            /* Tap starts disabled, until app requests mouse grab */
+            CGEventTapEnable(tapdata->tap, false);
             tapdata->thread = SDL_CreateThreadInternal(&Cocoa_MouseTapThread, "Event Tap Loop", 512 * 1024, tapdata);
             if (tapdata->thread) {
                 /* Success - early out. Ownership transferred to thread. */
@@ -222,7 +224,7 @@
     SDL_MouseEventTapData *tapdata = (SDL_MouseEventTapData*)driverdata->tapdata;
     if (tapdata && tapdata->tap)
     {
-        CGEventTapEnable(tapdata->tap, enabled);
+        CGEventTapEnable(tapdata->tap, !!enabled);
     }
 }