Skip to content

Commit

Permalink
Fixed bug 3535 - Misplaced comment #if/#endif closure comment
Browse files Browse the repository at this point in the history
Coriiander

This notice is about a misplaced comment.

Often times when we use an #if #endif sequence, the #endif is followed by a comment to indicate what #if statement it belonged to. The SDL_xaudio2.c file contains a misplaced comment, as follows (I stripped the other comments):

#ifdef __GNUC__
#  define SDL_XAUDIO2_HAS_SDK 1
#elif defined(__WINRT__)
#  define SDL_XAUDIO2_HAS_SDK
#include "SDL_xaudio2.h"
#else
#if 0
#include <dxsdkver.h>
#if (!defined(_DXSDK_BUILD_MAJOR) || (_DXSDK_BUILD_MAJOR < 1284))
#  pragma message("Your DirectX SDK is too old. Disabling XAudio2 support.")
#else
#  define SDL_XAUDIO2_HAS_SDK 1
#endif
#endif
#endif /* 0 */



That final /* 0 */ should be moved one line up. Like this (I tabbed it out for you to make it more clear):
  • Loading branch information
slouken committed Jan 1, 2017
1 parent 880842c commit 2ba66d0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/audio/xaudio2/SDL_xaudio2.c
Expand Up @@ -78,8 +78,8 @@
#else
# define SDL_XAUDIO2_HAS_SDK 1
#endif
#endif
#endif /* 0 */
#endif /* __GNUC__ */

#ifdef SDL_XAUDIO2_HAS_SDK

Expand Down

0 comments on commit 2ba66d0

Please sign in to comment.