Brian Fisher fixed bug #513 SDL-1.2
authorSam Lantinga <slouken@libsdl.org>
Fri, 28 Dec 2007 08:00:30 +0000
branchSDL-1.2
changeset 4099822f9624f984
parent 4098 60fa95a89846
child 4100 ad8bdb215737
Brian Fisher fixed bug #513

If an app requests a 24-bit opengl mode on a machine with a 32-bit desktop with
the windib video backend, then when exiting fullscreen the desktop resolution
is not restored

The reason this is, is because the windib backend restores the desktop
resolution when exiting fullscreen in DIB_SetVideoMode when it finds that the
last request was for fullscreen by checking the original flags on the video
surface. However, if the bits per pixel requested is different than current
surface, the video surface is recreated and the original video flags are lost.
So the check to see if we were exiting fullscreen fails.

below is a patch to SDL_dibvideo.c that solves the problem by using the
original flags in all cases.

thanks!
src/video/windib/SDL_dibvideo.c
     1.1 --- a/src/video/windib/SDL_dibvideo.c	Fri Dec 28 07:52:19 2007 +0000
     1.2 +++ b/src/video/windib/SDL_dibvideo.c	Fri Dec 28 08:00:30 2007 +0000
     1.3 @@ -484,6 +484,8 @@
     1.4  	int x, y;
     1.5  	Uint32 Rmask, Gmask, Bmask;
     1.6  
     1.7 +	prev_flags = current->flags;
     1.8 +
     1.9  	/* Clean up any GL context that may be hanging around */
    1.10  	if ( current->flags & SDL_OPENGL ) {
    1.11  		WIN_GL_ShutDown(this);
    1.12 @@ -531,7 +533,6 @@
    1.13  	}
    1.14  
    1.15  	/* Fill in part of the video surface */
    1.16 -	prev_flags = video->flags;
    1.17  	prev_w = video->w;
    1.18  	prev_h = video->h;
    1.19  	video->flags = 0;	/* Clear flags */