Fixed bug 4837 - Use after free in SDL_SensorUpdate (Thanks!)

libsdl-org · Oct 23, 2019 · 3ac67cf · 3ac67cf
1 parent 5025109
commit 3ac67cf
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/sensor/SDL_sensor.c b/src/sensor/SDL_sensor.c
@@ -503,7 +503,7 @@ void
 SDL_SensorUpdate(void)
 {
     int i;
-    SDL_Sensor *sensor;
+    SDL_Sensor *sensor, *next;
 
     if (!SDL_WasInit(SDL_INIT_SENSOR)) {
         return;
@@ -531,7 +531,8 @@ SDL_SensorUpdate(void)
     SDL_updating_sensor = SDL_FALSE;
 
     /* If any sensors were closed while updating, free them here */
-    for (sensor = SDL_sensors; sensor; sensor = sensor->next) {
+    for (sensor = SDL_sensors; sensor; sensor = next) {
+        next = sensor->next;
         if (sensor->ref_count <= 0) {
             SDL_SensorClose(sensor);
         }