Adam Strzelecki to SDL

Currently SDL uses GL_RGB for internalFormat when GL_YCBCR_MESA is passed as format for glTextImage2D when using Linux Mesa's OpenGL. However this is wrong and makes glTextImage2D fail with invalid argument error. GL_YCBCR_MESA should be also internalFormat (not GL_RGB) there and this is what can be found googling various source codes using GL_YCBCR_MESA.
libsdl-org · Nov 26, 2009 · 4369a54 · 4369a54
1 parent fc18228
commit 4369a54
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/video/SDL_renderer_gl.c b/src/video/SDL_renderer_gl.c
@@ -707,7 +707,7 @@ convert_format(GL_RenderData *renderdata, Uint32 pixel_format,
             *type = GL_UNSIGNED_SHORT_8_8_REV_APPLE;
 #endif
         } else if (renderdata->GL_MESA_ycbcr_texture_supported) {
-            *internalFormat = GL_RGB;
+            *internalFormat = GL_YCBCR_MESA;
             *format = GL_YCBCR_MESA;
 #if SDL_BYTEORDER == SDL_LIL_ENDIAN
             *type = GL_UNSIGNED_SHORT_8_8_MESA;
@@ -732,7 +732,7 @@ convert_format(GL_RenderData *renderdata, Uint32 pixel_format,
             *type = GL_UNSIGNED_SHORT_8_8_APPLE;
 #endif
         } else if (renderdata->GL_MESA_ycbcr_texture_supported) {
-            *internalFormat = GL_RGB;
+            *internalFormat = GL_YCBCR_MESA;
             *format = GL_YCBCR_MESA;
 #if SDL_BYTEORDER == SDL_LIL_ENDIAN
             *type = GL_UNSIGNED_SHORT_8_8_REV_MESA;