Date: Tue, 05 Jul 2005 21:43:26 +1000
authorSam Lantinga <slouken@libsdl.org>
Tue, 31 Jan 2006 15:30:42 +0000
changeset 130352b5afd7ecee
parent 1302 94643e9bad18
child 1304 0175d3eeae89
Date: Tue, 05 Jul 2005 21:43:26 +1000
From: Sean Childs
Subject: [SDL] Compiling SDL 1.2.8 with the free Borland compiler

When compiling SDL 1.2.8 with the free Borland compiler, I received this
error (there is a similar error that occurs in
src\video\windx5\sdl_dx5events.c):
Error E2342 ..\..\src\video\windib\sdl_dibevents.c 189: Type mismatch in
parameter 'lpPrevWndFunc' (wanted 'int (__stdcall *)()', got 'long
(__stdcall *)(void *,unsigned int,unsigned int,long)') in function
DIB_HandleMessage


I checked the MSDN library at:
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/winui/winui/
windowsuserinterface/windowing/windowprocedures/windowprocedurereference/wind
owprocedurefunctions/callwindowproc.asp

and it had this to say:
If STRICT is not defined, the lpPrevWndFunc parameter has the data type
FARPROC. The FARPROC type is declared as follows:

int (FAR WINAPI * FARPROC) ()

In C, the FARPROC declaration indicates a callback function that has an
unspecified parameter list. In C++, however, the empty parameter list in
the declaration indicates that a function has no parameters. This subtle
distinction can break careless code. Following is one way to handle this
situation:

#ifdef STRICT
WNDPROC MyWindowProcedure
#else
FARPROC MyWindowProcedure
#endif
...
lResult = CallWindowProc(MyWindowProcedure, ...)
src/video/windib/SDL_dibevents.c
src/video/windx5/SDL_dx5events.c
     1.1 --- a/src/video/windib/SDL_dibevents.c	Tue Jan 31 14:59:43 2006 +0000
     1.2 +++ b/src/video/windib/SDL_dibevents.c	Tue Jan 31 15:30:42 2006 +0000
     1.3 @@ -56,7 +56,12 @@
     1.4  
     1.5  /* DJM: If the user setup the window for us, we want to save his window proc,
     1.6     and give him a chance to handle some messages. */
     1.7 -static WNDPROC userWindowProc = NULL;
     1.8 +#ifdef STRICT
     1.9 +#define WNDPROCTYPE	WNDPROC
    1.10 +#else
    1.11 +#define WNDPROCTYPE	FARPROC
    1.12 +#endif
    1.13 +static WNDPROCTYPE userWindowProc = NULL;
    1.14  
    1.15  
    1.16  #ifdef _WIN32_WCE
    1.17 @@ -427,7 +432,7 @@
    1.18  		/* DJM: we want all event's for the user specified
    1.19  			window to be handled by SDL.
    1.20  		 */
    1.21 -		userWindowProc = (WNDPROC)GetWindowLong(SDL_Window, GWL_WNDPROC);
    1.22 +		userWindowProc = (WNDPROCTYPE)GetWindowLong(SDL_Window, GWL_WNDPROC);
    1.23  		SetWindowLong(SDL_Window, GWL_WNDPROC, (LONG)WinMessage);
    1.24  	} else {
    1.25  		SDL_Window = CreateWindow(SDL_Appname, SDL_Appname,
     2.1 --- a/src/video/windx5/SDL_dx5events.c	Tue Jan 31 14:59:43 2006 +0000
     2.2 +++ b/src/video/windx5/SDL_dx5events.c	Tue Jan 31 15:30:42 2006 +0000
     2.3 @@ -66,7 +66,12 @@
     2.4  
     2.5  /* DJM: If the user setup the window for us, we want to save his window proc,
     2.6     and give him a chance to handle some messages. */
     2.7 -static WNDPROC userWindowProc = NULL;
     2.8 +#ifdef STRICT
     2.9 +#define WNDPROCTYPE	WNDPROC
    2.10 +#else
    2.11 +#define WNDPROCTYPE	FARPROC
    2.12 +#endif
    2.13 +static WNDPROCTYPE userWindowProc = NULL;
    2.14  
    2.15  static HWND GetTopLevelParent(HWND hWnd)
    2.16  {
    2.17 @@ -871,7 +876,7 @@
    2.18  		/* DJM: we want all event's for the user specified
    2.19  			window to be handled by SDL.
    2.20  		 */
    2.21 -		userWindowProc = (WNDPROC)GetWindowLong(SDL_Window, GWL_WNDPROC);
    2.22 +		userWindowProc = (WNDPROCTYPE)GetWindowLong(SDL_Window, GWL_WNDPROC);
    2.23  		SetWindowLong(SDL_Window, GWL_WNDPROC, (LONG)WinMessage);
    2.24  	} else {
    2.25  		SDL_Window = CreateWindow(SDL_Appname, SDL_Appname,