Don't re-read the hints when opening the game controller. Instead use…

… SDL_GameControllerAddMapping() to add hints after initialization.
libsdl-org · Mar 8, 2013 · 15296eb · 15296eb
1 parent a2a777e
commit 15296eb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/include/SDL_hints.h b/include/SDL_hints.h
@@ -209,6 +209,9 @@ extern "C" {
  *  \brief  A variable that lets you manually hint extra gamecontroller db entries
  *
  *  The variable expected newline delimited rows of gamecontroller config data, see SDL_gamecontroller.h
+ *
+ *  This hint must be set before calling SDL_Init(SDL_INIT_GAMECONTROLLER)
+ *  You can update hints after the system is initialized with SDL_GameControllerAddMapping()
  */
 #define SDL_HINT_GAMECONTROLLERCONFIG "SDL_GAMECONTROLLERCONFIG"
 

diff --git a/src/joystick/SDL_gamecontroller.c b/src/joystick/SDL_gamecontroller.c
@@ -879,8 +879,6 @@ SDL_GameControllerOpen(int device_index)
     }
 
 	// Find a controller mapping 
-    // Check for hints in case someone has changed them recently
-    SDL_GameControllerLoadHints();
 	pSupportedController =  SDL_PrivateGetControllerMapping(device_index);
 	if ( !pSupportedController ) {
 		SDL_SetError("Couldn't find mapping for device (%d)", device_index );