Steven Noonan to sdl SDL-1.2
authorSam Lantinga <slouken@libsdl.org>
Mon, 12 Oct 2009 21:07:12 +0000
branchSDL-1.2
changeset 43241496aa09e41e
parent 4323 b3171b7561d8
child 4325 df4108bfbe1e
Steven Noonan to sdl

While trying to build the SDLMain.m included with SDL 1.2.14, with
#define SDL_USE_NIB_FILE 1:

/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:
In function '-[SDLMain fixMenu:withAppName:]':
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:122:
warning: 'sizeToFit' is deprecated (declared at
/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSMenu.h:281)
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:
In function 'main':
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:376:
warning: 'poseAsClass:' is deprecated (declared at
/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSObject.h:127)
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:376:
error: 'poseAsClass:' is unavailable (declared at
/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSObject.h:127)
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:377:
warning: passing argument 2 of 'NSApplicationMain' from incompatible
pointer type



Eric Wing to Sam

I don't have time today to look at this in detail, but the problem is definitely the poseAsClass: method.
This was deprecated in Obj-C 2.0 and not retained in 64-bit.

I've never used this method and it has always been limited to esoteric uses. I think this is why Apple wanted to dump it (among complicating some other things they do). I have read about others getting bit by this when migrating. Long story short, there really isn't a migration path for this method. The question that then must be asked is why are we using it (what does it accomplish), and then figure out the 'proper' way of accomplishing that.

Glancing at SDLMain.m, it's not obvious to me why it is there or what it is really accomplishing. My only speculation is that NSApplicationMain hardcodes something to look for NSApplication and a subclass (SDLApplication) fails for some reason (assuming that the original coder did this for good reason).

Three thoughts come to mind.
1) The Info.plist has properties to control things related to the startup class and nib.
NSPrincipalClass, NSMainNibFile

Maybe principle class needs to be SDLApplication and we can delete the poseAs

2) I was told that 10.6 introduced new APIs to make programatic NIB wrangling and avoidance easier. Unfortunately, I don't know the specifics.


3) Instead of subclassing NSApplication in SDLMain.m, maybe we can just add a category. It looks like the following is the only thing that is done (quick glance):

@interface SDLApplication : NSApplication
@end

@implementation SDLApplication
/* Invoked from the Quit menu item */
- (void)terminate:(id)sender
{
/* Post a SDL_QUIT event */
SDL_Event event;
event.type = SDL_QUIT;
SDL_PushEvent(&event);
}
@end


So instead, we change this to: (warning written in mail and untested)

@interface NSApplication (SDLApplication)
- (void) terminate:(id)sender;
@end

@implementation NSApplication (SDLApplication)
/* Invoked from the Quit menu item */
- (void)terminate:(id)sender
{
/* Post a SDL_QUIT event */
SDL_Event event;
event.type = SDL_QUIT;
SDL_PushEvent(&event);
}
@end


Then everywhere SDLApplication is used, we change it to NSApplication (and remove the poseAsClass line).

Perhaps you could ask the bug reporter to try this solution (#3).
And if that fails, maybe try #1.


-Eric


Steven Noonan to Sam

The suggested change (diff below) seems to work fine.

- Steven
src/main/macosx/SDLMain.m
     1.1 --- a/src/main/macosx/SDLMain.m	Mon Oct 12 09:32:55 2009 +0000
     1.2 +++ b/src/main/macosx/SDLMain.m	Mon Oct 12 21:07:12 2009 +0000
     1.3 @@ -64,10 +64,10 @@
     1.4  @end
     1.5  #endif
     1.6  
     1.7 -@interface SDLApplication : NSApplication
     1.8 +@interface NSApplication (SDLApplication)
     1.9  @end
    1.10  
    1.11 -@implementation SDLApplication
    1.12 +@implementation NSApplication (SDLApplication)
    1.13  /* Invoked from the Quit menu item */
    1.14  - (void)terminate:(id)sender
    1.15  {
    1.16 @@ -119,7 +119,6 @@
    1.17          if ([menuItem hasSubmenu])
    1.18              [self fixMenu:[menuItem submenu] withAppName:appName];
    1.19      }
    1.20 -    [ aMenu sizeToFit ];
    1.21  }
    1.22  
    1.23  #else
    1.24 @@ -373,7 +372,6 @@
    1.25      }
    1.26  
    1.27  #if SDL_USE_NIB_FILE
    1.28 -    [SDLApplication poseAsClass:[NSApplication class]];
    1.29      NSApplicationMain (argc, argv);
    1.30  #else
    1.31      CustomApplicationMain (argc, argv);