Navigation Menu

Skip to content

Commit

Permalink
Fixed memory barrier macro check so it isn't quite so fragile
Browse files Browse the repository at this point in the history
  • Loading branch information
slouken committed Jul 1, 2019
1 parent a8bea85 commit 959cfc4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions include/SDL_atomic.h
Expand Up @@ -184,6 +184,7 @@ typedef void (*SDL_KernelMemoryBarrierFunc)();
#elif defined(__ARM_ARCH_6__) || defined(__ARM_ARCH_6J__) || defined(__ARM_ARCH_6K__) || defined(__ARM_ARCH_6T2__) || defined(__ARM_ARCH_6Z__) || defined(__ARM_ARCH_6ZK__) || defined(__ARM_ARCH_5TE__)
#ifdef __thumb__
/* The mcr instruction isn't available in thumb mode, use real functions */
#define SDL_MEMORY_BARRIER_USES_FUNCTION
#define SDL_MemoryBarrierRelease() SDL_MemoryBarrierReleaseFunction()
#define SDL_MemoryBarrierAcquire() SDL_MemoryBarrierAcquireFunction()
#else
Expand Down
2 changes: 1 addition & 1 deletion src/atomic/SDL_atomic.c
Expand Up @@ -289,7 +289,7 @@ SDL_AtomicGetPtr(void **a)
#endif
}

#if defined(__thumb__) && (defined(__ARM_ARCH_6__) || defined(__ARM_ARCH_6J__) || defined(__ARM_ARCH_6K__) || defined(__ARM_ARCH_6T2__) || defined(__ARM_ARCH_6Z__) || defined(__ARM_ARCH_6ZK__) || defined(__ARM_ARCH_5TE__))
#ifdef SDL_MEMORY_BARRIER_USES_FUNCTION
#error This file should be built in arm mode so the mcr instruction is available for memory barriers
#endif

Expand Down

0 comments on commit 959cfc4

Please sign in to comment.