HandleEvent() returns done each time it is called. If done was set to 0 the program should quit, but because done is not checked until *all* events are handled a
authorBob Pendleton <bob@pendleton.com>
Wed, 20 Feb 2008 23:27:33 +0000
changeset 23180c653886cce7
parent 2317 f537a293b3da
child 2319 5835745560bf
HandleEvent() returns done each time it is called. If done was set to 0 the program should quit, but because done is not checked until *all* events are handled a
following event can reset done to 1 and prevent the program from terminating when told to. I fixed the while loop that handles events to check for the state of done
after handling each event. That could leave some events unhandled when the program exits, but it ensures that the program will exit.
test/testgl.c
     1.1 --- a/test/testgl.c	Mon Feb 11 21:06:32 2008 +0000
     1.2 +++ b/test/testgl.c	Wed Feb 20 23:27:33 2008 +0000
     1.3 @@ -666,7 +666,7 @@
     1.4          }
     1.5  
     1.6          /* Check if there's a pending event. */
     1.7 -        while (SDL_PollEvent(&event)) {
     1.8 +        while (!done && SDL_PollEvent(&event)) {
     1.9              done = HandleEvent(&event);
    1.10          }
    1.11          ++frames;