SDL_FillRects: prevent empty SDL_surface from raising an error message

It's legitimate to have a surface with 0 width or height (null 'pixels' pointer). But calling SDL_FillRects would wrongly set the error "You must lock the surface".
libsdl-org · Nov 27, 2020 · 2c079a2 · 2c079a2
1 parent 3fbff2a
commit 2c079a2
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/video/SDL_fillrect.c b/src/video/SDL_fillrect.c
@@ -314,6 +314,11 @@ SDL_FillRects(SDL_Surface * dst, const SDL_Rect * rects, int count,
         return SDL_SetError("SDL_FillRect(): Unsupported surface format");
     }
 
+    /* Nothing to do */
+    if (dst->w == 0 || dst->h == 0) {
+        return 0;
+    }
+
     /* Perform software fill */
     if (!dst->pixels) {
         return SDL_SetError("SDL_FillRect(): You must lock the surface");