Fri, 10 Feb 2006 03:21:39 +0000Whoops, need this. :)
Sam Lantinga [Fri, 10 Feb 2006 03:21:39 +0000] rev 1357
Whoops, need this. :)

Fri, 10 Feb 2006 03:19:02 +0000*** empty log message ***
Sam Lantinga [Fri, 10 Feb 2006 03:19:02 +0000] rev 1356
*** empty log message ***

Fri, 10 Feb 2006 03:00:38 +0000*** empty log message ***
Sam Lantinga [Fri, 10 Feb 2006 03:00:38 +0000] rev 1355
*** empty log message ***

Thu, 09 Feb 2006 09:38:05 +0000Fixed build problem with SDL_string.c
Sam Lantinga [Thu, 09 Feb 2006 09:38:05 +0000] rev 1354
Fixed build problem with SDL_string.c
Officially deprecated SDL_byteorder.h, SDL_getenv.h and SDL_types.h
Moved endian-related SDL_rwops code into SDL_rwops.c

Thu, 09 Feb 2006 09:07:13 +0000Started the process of improving configure support, and merging C types
Sam Lantinga [Thu, 09 Feb 2006 09:07:13 +0000] rev 1353
Started the process of improving configure support, and merging C types
and library support into a single header.

Thu, 09 Feb 2006 05:46:55 +0000Disable freaking autoheader. :)
Sam Lantinga [Thu, 09 Feb 2006 05:46:55 +0000] rev 1352
Disable freaking autoheader. :)

Wed, 08 Feb 2006 20:29:12 +0000Changed X11 header order so it works on Solaris.
Ryan C. Gordon [Wed, 08 Feb 2006 20:29:12 +0000] rev 1351
Changed X11 header order so it works on Solaris.

Fixes Bugzilla #138.

--ryan.

Wed, 08 Feb 2006 18:59:49 +0000Fixes for new SDL embedded libc stuff
Patrice Mandin [Wed, 08 Feb 2006 18:59:49 +0000] rev 1350
Fixes for new SDL embedded libc stuff

Wed, 08 Feb 2006 17:23:32 +0000*** empty log message ***
Sam Lantinga [Wed, 08 Feb 2006 17:23:32 +0000] rev 1349
*** empty log message ***

Wed, 08 Feb 2006 17:19:43 +0000Date: Mon, 6 Feb 2006 11:41:04 -0500
Sam Lantinga [Wed, 08 Feb 2006 17:19:43 +0000] rev 1348
Date: Mon, 6 Feb 2006 11:41:04 -0500
From: "mystml@adinet.com.uy"
Subject: [SDL] ALT-F4 using DirectX

My game isn't getting SDL_QUIT when I press ALT-F4 using the DirectX
driver; it does get SDL_QUIT when I press the red X in the window.

I tracked this down to DX5_HandleMessage() in SDL_dx5events.c;
WM_SYSKEYDOWN is being trapped and ignored which causes Windows not to post
a WM_CLOSE, hence no SDL_QUIT is being generated.

The relevant code is this :

/* The keyboard is handled via DirectInput */
case WM_SYSKEYUP:
case WM_SYSKEYDOWN:
case WM_KEYUP:
case WM_KEYDOWN: {
/* Ignore windows keyboard messages */;
}
return(0);

If I comment the WM_SYSKEYDOWN case, it falls through DefWindowProc() and
ALT-F4 starts working again.

I'm not sure about the best way to fix this. One option is handling ALT-F4
as a particular case somehow, but doesn't sound good. Another option would
be to handle WM_SYSKEYDOWN separately and breaking instead of returning 0,
so processing falls through and goes to DefWindowProc which does The Right
Thing (TM). This seems to be the minimal change that makes ALT-F4 work and
normal keyboard input continues to work.

Does this sound reasonable? Am I overlooking anything? Do I submit a patch?

--Gabriel