Fix for expression error by Torsten Giebl - Thanks! :)

Fixed bug #638

Philipp Nordhus 2008-11-05 13:56:33 PST

The Linux version of SDL_SYS_JoystickQuit() tries to free an invalid pointer
when the number of joysticks was reduced since the last call.

Reproduce: Connect two joysticks, call SDL_Init() and SDL_Quit(), then
disconnect one joystick and call the functions again.

Fixed bug #637

Switched right click emulation to be Ctrl-click, which matches Mac OS X

Whoops, need both the header and the library!

Fixed bug #727

Lorenzo Desole 2009-04-19 07:36:10 PDT

I am one of the developers of a multimedia application (My Media System MMS),
which uses SDL.

MMS is normally running in fullscreen mode but it switches it off before
launching external applications (mplayer, xine, etc.).

The problem with fullscreen is that when the latter is switched off either via
SDL_WM_ToggleFullScreen() or SDL_SetVideoMode(), SDL compares the current
screen sizes with the ones saved when the video system was initted, and if they
don't match, it calls XF86VidModeSwitchToMode() to switch to the old modeline.

This makes it impossible for external programs and for MMS itself to use RandR
to change the screen size, because next time fullscreen mode is turned off, it
bombs out with the following error:

X Error of failed request: BadValue (integer parameter out of range for
operation)
Major opcode of failed request: 136 (XFree86-VidModeExtension)
Minor opcode of failed request: 10 (XF86VidModeSwitchToMode)
[...]

Obviously this happens only if the new screen resolution is smaller than the
original one and XF86VidModeSwitchToMode() can't succeed.

I couldn't find any way to inform SDL that the screen resolution it uses as
reference is no longer valid.

This can be fixed by adding "save_mode(this)" to
./src/video/x11/SDL_x11modes.c, API X11_EnterFullScreen(_THIS), like this:

int X11_EnterFullScreen(_THIS)
{
int okay;
+ save_mode(this);

I can't rule out possible side effects, but I don't see any.

While I admit this is a minor issue for the general users, it is a major
showstopper for our program where the ability to change screen resolution and
refresh rate according to the movie being played, is very important.

Thanks in advance.

Fixed bug #714

fuzzyTew@gmail.com 2009-03-14 15:18:45 PDT

Created an attachment (id=305) [details]
patch to change HAVE_ICONV to HAVE_ICONV_H

There are two separate iconv checks in configure -- one for the header file and
one for the library. include/SDL_stdinc.h uses the library define to see
whether or not it should reference the types defined in the header, which
naturally breaks if the library exists and the header does not.

Fixed bug #674

Matej 2009-01-08 09:25:34 PST

Hello,
I maintain a cross-platform project that uses SDL.
One of the users who runs OSX has told me that he has problems with linking to
SDL due to missing -framework option.
I think that the problem is because of this:
'sdl-config --libs' outputs '-L/opt/local/lib -lSDLmain -lSDL
-Wl,-framework,Cocoa'
All the options are passed to the linker except the last one. I think that the
good output should be just:
'-L/opt/local/lib -lSDLmain -lSDL -framework Cocoa'
since those options (--libs) are passed to the linker, so the '-Wl' option is
redundant and possibly harmful in this very case
I use autotools with libtool to do the build...
Regards,
Matej

Fixed bug #795

Andrey 2009-09-14 21:16:53 PDT

WinCE GetCursorPos fixed

I'm using iPAQ HP rx5919, with Windows Mobile 5.
And I also use mingw32ce 0.59.1 toolchain.
I fixed this, see attachment patch.

Fixed bug #695

Nomad 2009-02-08 10:34:43 PST

The 2nd init is good.
The problem is in "SDL_dibevents.c"
in DIB_CreateWindow()

in SVN:
{
char *windowid = SDL_getenv("SDL_WINDOWID");

SDL_RegisterApp(NULL, 0, 0);

... using of data to which windowid is points

problem:
SDL_RegisterApp() may call SDL_getenv() and windowid will point to some
wrong string

solve:
char *windowid;

SDL_RegisterApp(NULL, 0, 0);

windowid = SDL_getenv("SDL_WINDOWID");

Fixed bug #778

Derek Weitzel 2009-08-11 12:17:09 PDT

Window Manager: xorg-x11-twm-1.0.1-3.1

Running through Xdmx. The same application could expand to the full screen
using GLUT (freeglut).

Overview:
While running on a very high resolution display, discovered the maximium width
of the window is 4096.