Mon, 19 Oct 2009 05:15:21 +0000Added an error message for when ALSA audio fails SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Mon, 19 Oct 2009 05:15:21 +0000] rev 4361
Added an error message for when ALSA audio fails

Mon, 19 Oct 2009 03:18:15 +0000Getting as close as you can with periods is better than the default parameters. SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Mon, 19 Oct 2009 03:18:15 +0000] rev 4360
Getting as close as you can with periods is better than the default parameters.

Mon, 19 Oct 2009 02:36:02 +0000Recoomendation from Lennart Poettering: SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Mon, 19 Oct 2009 02:36:02 +0000] rev 4359
Recoomendation from Lennart Poettering:

I guess I don't have to mention that, but ALSA_WaitAudio() is
pure evil, and just broken. getpid() returns pids, not tids. You get
those via gettid(). But I'd recommend dropping that entirely. It's
just broken.

Mon, 19 Oct 2009 02:33:07 +0000Recommendation from Lennart Poettering: SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Mon, 19 Oct 2009 02:33:07 +0000] rev 4358
Recommendation from Lennart Poettering:

In ALSA_PlayAudio() it is a good idea to use snd_pcm_recover() instead
of checking for the error codes yourself.

Mon, 19 Oct 2009 02:23:21 +0000Recommendation from Lennart Poettering: SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Mon, 19 Oct 2009 02:23:21 +0000] rev 4357
Recommendation from Lennart Poettering:

In ALSA_OpenAudio(): instead of setting period_size+n_periods OR
buffer_size I'd recommend copying the hwparams stuff before you do
this, then first try period_size+n_periods, and then apply it with
snd_pcm_hw_params() and check if that works. If it didn't you should
take the copy of hwparams and try setting buffer_size and apply that
via snd_pcm_hw_params() and check if that worked. And if that failed
too, then take the copy and don't apply neither period nor buffer
settings and see if that works.

Sun, 18 Oct 2009 23:18:28 +0000There's a bug with gcc 4.4.1 and -O2 where srcp doesn't get the correct value after the first scanline. Ugh. SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Sun, 18 Oct 2009 23:18:28 +0000] rev 4356
There's a bug with gcc 4.4.1 and -O2 where srcp doesn't get the correct value after the first scanline. Ugh.

Sun, 18 Oct 2009 17:31:37 +0000Fixed bug #855 SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Sun, 18 Oct 2009 17:31:37 +0000] rev 4355
Fixed bug #855

Ludwig Nussel 2009-10-18 06:31:52 PDT

an mprotect call was added to fix bug 528. However that results in a buffer
that allows writing and code execution. Ie the no-execute security features of
modern operating systems are defeated this way. Two mprotect calls are needed.
One to make the buffer executable but not writeable when done and another one
to make the buffer writeable again if the content needs to be changed.

Sun, 18 Oct 2009 16:23:12 +0000Use MacOS line endings for Mac resource files SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Sun, 18 Oct 2009 16:23:12 +0000] rev 4354
Use MacOS line endings for Mac resource files

Sun, 18 Oct 2009 16:17:13 +0000Use MacOS line endings for SDL.x SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Sun, 18 Oct 2009 16:17:13 +0000] rev 4353
Use MacOS line endings for SDL.x

Sun, 18 Oct 2009 16:14:57 +0000Fixed bug #853 SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Sun, 18 Oct 2009 16:14:57 +0000] rev 4352
Fixed bug #853

Ludwig Nussel 2009-10-18 05:34:18 PDT

src/joystick/linux/SDL_sysjoystick.c has some problems:

- test_bit() might break with strict aliasing
- test_bit() assumes array is Uint32 but its actually "unsigned long"
on 64bit systems sizeof(long) != sizeof(Uint32).
- the keybit array is too small
- the arrays are unitialized so the number of
detected buttons is quite random