Sat, 08 Jun 2019 14:34:38 -0700Fixed bug 4594 - Fix install location of CMake targets on Apple platforms
Sam Lantinga [Sat, 08 Jun 2019 14:34:38 -0700] rev 12791
Fixed bug 4594 - Fix install location of CMake targets on Apple platforms

tschwinger

Followup to #3651

As already noted by Ryan, no framework is being built, so we better install to lib/cmake.

That code was originally part of a patch submitted by David Demelier, whose credit BTW got lost (I combined his patch for #3572 with fixes for #2576 and #3613 resulting in #3651 because things started to depend on another).

I tested that the configuration files are found correctly in the new location on MacOS X based on a hint to the root (see https://cmake.org/cmake/help/latest/command/find_package.html#search-procedure).

Sat, 08 Jun 2019 14:32:19 -0700Fixed bug 4600 - Dualshock 4 touchpad press is not detectable with SDL_JoystickGetButton
Sam Lantinga [Sat, 08 Jun 2019 14:32:19 -0700] rev 12790
Fixed bug 4600 - Dualshock 4 touchpad press is not detectable with SDL_JoystickGetButton

Dexter Friedman

When using a Dualshock 4 controller (model numbers CUH-ZCT1U and CUH-ZCT2U), pressing anywhere on the center touchpad does not send an SDL_JOYBUTTONDOWN event. I have verified this with testjoystick:

Repro steps:
1. Plug in a DS4 over USB
2. Compile testjoystick and run: testjoystick.exe 0
3. Press and hold the touchpad. Observe that no lime green box appears

Expected behavior:
A lime green box appears while the touchpad is pressed.

Notes:
I've attached a patch here that works on my PC and produces the expected behavior in testjoystick, for both DS4 model numbers I listed earlier.

If I understand correctly, by exposing this as a joystick button, the gamecontroller API mapping can be modified with a change to gamecontrollerdb.txt in the future.

Sat, 08 Jun 2019 14:29:05 -0700Fixed bug 4603 - The iOS Test Xcode project file needs to add the metal framework
Sam Lantinga [Sat, 08 Jun 2019 14:29:05 -0700] rev 12789
Fixed bug 4603 - The iOS Test Xcode project file needs to add the metal framework

Dominik Reichardt

Similar to bug #4088 the iOS test suite needs the metal framework to link. Same linking error in the final linking phase.

Sat, 08 Jun 2019 13:41:46 -0700Fixed bug 4605 - WASAPI_WaitDevice hang
Sam Lantinga [Sat, 08 Jun 2019 13:41:46 -0700] rev 12788
Fixed bug 4605 - WASAPI_WaitDevice hang

Matt Brocklehurst

We've noticed that if you are playing audio on Windows via the WASAPI interface and you unplug and reconnect the device a few times the program hangs.

We've debugged the problem down to

static void
WASAPI_WaitDevice(_THIS)
{

... snip ...
if (WaitForSingleObjectEx(this->hidden->event, INFINITE, FALSE) == WAIT_OBJECT_0) {
... snip ...
}

This WaitForSingleObjectEx does not havbe a time out defined, so it hangs there forever.

Our suggested fix we found was to include a time out of say 200mSec

We have done quite a bit of testing with this fix in place on various hardware configurations and it seems to have resolved the issue.

Sat, 08 Jun 2019 13:36:59 -0700hidapi: Use GameCube adapter controller port for player index
Zack Middleton [Sat, 08 Jun 2019 13:36:59 -0700] rev 12787
hidapi: Use GameCube adapter controller port for player index
The Nintendo USB GameCube adapter has four controller ports. Return
the port number as 0 to 3 from SDL_JoystickGetPlayerIndex() and
SDL_JoystickGetDevicePlayerIndex().

Sat, 01 Jun 2019 18:27:46 +0100riscos: Add support for more pixel formats SDL-1.2
Jeffrey Lee [Sat, 01 Jun 2019 18:27:46 +0100] rev 12786
riscos: Add support for more pixel formats

* Add support for red/blue swapped, 12bpp, and 16bpp screen modes
* Clean up code a bit by moving all local 'extern' declarations into headers & making local functions static
* Fix toggling to fullscreen to retain the current palette

Fri, 31 May 2019 00:26:21 +0100riscos: Remove obsolete unixlib includes SDL-1.2
Jeffrey Lee [Fri, 31 May 2019 00:26:21 +0100] rev 12785
riscos: Remove obsolete unixlib includes

Fri, 31 May 2019 00:22:44 +0100riscos: Fix thread starvation in fullscreen mode SDL-1.2
Jeffrey Lee [Fri, 31 May 2019 00:22:44 +0100] rev 12784
riscos: Fix thread starvation in fullscreen mode

Sat, 01 Jun 2019 19:26:50 +0100riscos: Mouse fixes SDL-1.2
Jeffrey Lee [Sat, 01 Jun 2019 19:26:50 +0100] rev 12783
riscos: Mouse fixes

* FULLSCREEN_WarpWMCursor pixel to OS unit conversion fixed to invert Y axis. Also, avoid redundant SWI to read eigen values
* RISCOS_PollMouseHelper mouse re-centreing fixed to use 90 DPI coordinate scaling
* Added some extra comments for clarity (fullscreen & windowed modes are always handled as 90 DPI)

Sun, 26 May 2019 12:02:02 +0100riscos: Ensure the window size is consistent at different DPIs SDL-1.2
Jeffrey Lee [Sun, 26 May 2019 12:02:02 +0100] rev 12782
riscos: Ensure the window size is consistent at different DPIs