Thu, 03 Dec 2009 04:20:46 +0000Missing pop over a jump SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Thu, 03 Dec 2009 04:20:46 +0000] rev 4387
Missing pop over a jump

Wed, 02 Dec 2009 16:24:21 +0000Fixed crash - need to save and restore rbx around cpuid, since the compiler may be assuming the stack pointer isn't being modified when filling in %0. SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Wed, 02 Dec 2009 16:24:21 +0000] rev 4386
Fixed crash - need to save and restore rbx around cpuid, since the compiler may be assuming the stack pointer isn't being modified when filling in %0.

I did it around each call to cpuid which isn't strictly necessary, but is definitely future proof. :)

Tue, 17 Nov 2009 05:14:23 +0000Fixed bug #888 SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Tue, 17 Nov 2009 05:14:23 +0000] rev 4385
Fixed bug #888

The OS/2 joystick code included an IBM header and was in violation of the license.
Ryan may put this back someday with a legal header. :)

Tue, 17 Nov 2009 04:59:13 +0000Fixed bugs #882 and 865, re-opening bug #634 SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Tue, 17 Nov 2009 04:59:13 +0000] rev 4384
Fixed bugs #882 and 865, re-opening bug #634

Ronald Lamprecht to SDL

Hi,

Sam Lantinga wrote:

The problem with that fix is that it breaks IME events again. Maybe
we can handle keyboard events differently to prevent this issue?


Spending an hour reading MSDN, analysing SDL and another hour testing the reality on XP I am really wondering how patch r4990 could have ever worked in any situation. It's main effect is to break the unicode translation and causing spurious activation events!

Why does TranslateMessage(&msg) nothing useful? Simply because it does not affect "msg" at all! All keyboard events are dispatched without the slightest change (see MSDN). TranslateMessage() just appends additional WM_CHAR, WM_DEADCHAR, WM_SYSCHAR, WM_SYSDEADCHAR event messages to the queue. But I could not find any SDL event handling routine that catches these events and transforms them to proper SDL keyevents while eliminating the corresponding WM_KEYDOWN, etc. events. Thus any IME input like the '@' generated by "Alt + 6(Numpad) + 4(Numpad)" is simply lost.

But the situation is even worse! Up to r4990 the TranslateKey()/ToUnicode() calls did evaluate dead keys and did deliver proper key events for subsequent key strokes like '´' + 'e' resulting in 'é'. ToUnicode() needs proper key state informations to be able to handle these substitutions. But unfortunatly TranslateMessage() needs the same state information and eats it up while generating the WM_CHAR messages :-( Thus the current 1.2.14 breakes the partial IME support of previous releases, too.

The key state race condition between ToUnicode() and TranslateMessage() requires to avoid any ToUnicode() usage for receiving proper WM_CHAR, etc. messages generated by TranslateMessage(). (Yes - the '@' and 'é' appear as WM_CHAR messages when unicode is switched off).

The spurious SDL activation events are *not* caused by additional WM_ACTIVATE Windows messages! Besides DIB_HandleMessage() SDL_PrivateAppActive() is called by another source which I am not yet aware of - any hints?

Thus I do strongly recommend the deletion of the TranslateMessage(&msg) call as a quick fix.

A proper support of unicode and IME requires a clean SDL keyboard input concept first. Which SDL keyboards events should be transmitted to the app when the user presses '´' + 'e' ? Within the current unicode handling the first key stroke is hidden. Even though ToUnicode() delivers the proper key SDL does ignore it in TranslateKey(). Just the composed key event is transmitted to the app. That is what you expect for text input, but the app can no longer use keys like '^' as a key button because it will never receive a key event for it!

With a given concept it seems to be necessary to regenerate SDL key events out of the WM_CHAR, etc. events and to drop all related direct WM_KEYDOWN, etc. events while the remaining basic WM_KEYDOWN, etc. events would still have to result in SDL key events.

Anyway the source of the spurious WM_ACTIVATE should be located to avoid future trouble.

Greets,

Ronald

Sun, 15 Nov 2009 17:21:24 +0000Gregory Smith SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Sun, 15 Nov 2009 17:21:24 +0000] rev 4383
Gregory Smith

Another one for the "How did this ever work?" file: when
DX5_HandleMessage is called with WM_ACTIVATEAPP, it goes past the end
of the 2-element SDL_DIdev array and if there doesn't happen to be a 0
in the memory next to it, crashes. Patch against SVN attached.

Mon, 09 Nov 2009 18:02:32 +0000Forgot a check for Coldfire CPU SDL-1.2
Patrice Mandin <patmandin@gmail.com> [Mon, 09 Nov 2009 18:02:32 +0000] rev 4382
Forgot a check for Coldfire CPU

Sat, 07 Nov 2009 20:56:09 +0000Adapt timer code for Coldfire SDL-1.2
Patrice Mandin <patmandin@gmail.com> [Sat, 07 Nov 2009 20:56:09 +0000] rev 4381
Adapt timer code for Coldfire

Sat, 07 Nov 2009 20:45:45 +0000Adapt audio interrupts for Coldfire SDL-1.2
Patrice Mandin <patmandin@gmail.com> [Sat, 07 Nov 2009 20:45:45 +0000] rev 4380
Adapt audio interrupts for Coldfire

Sat, 07 Nov 2009 12:20:01 +0000Adapt XBIOS asm routine for Coldfire SDL-1.2
Patrice Mandin <patmandin@gmail.com> [Sat, 07 Nov 2009 12:20:01 +0000] rev 4379
Adapt XBIOS asm routine for Coldfire

Fri, 06 Nov 2009 22:43:51 +0000Damn. Need to be more careful with stack stuff. SDL-1.2
Patrice Mandin <patmandin@gmail.com> [Fri, 06 Nov 2009 22:43:51 +0000] rev 4378
Damn. Need to be more careful with stack stuff.