Thu, 16 May 2013 00:43:22 -0700Fixed bug 1846 - _allmul implementation in SDL_stdlib.c doesn't clean up the stack
Sam Lantinga <slouken@libsdl.org> [Thu, 16 May 2013 00:43:22 -0700] rev 7180
Fixed bug 1846 - _allmul implementation in SDL_stdlib.c doesn't clean up the stack

Colin Barrett

I see this manifest itself (VS2012 x86) as:

"Run-Time Check Failure #0 - The value of ESP was not properly saved across a function call. This is usually a result of calling a function declared with one calling convention with a function pointer declared with a different calling convention."

in the first call to SDL_GetTicks in my application. The disassembly at the problem line is:

hires_now.QuadPart *= 1000;
00AD0792 push 0
00AD0794 push 3E8h
00AD0799 mov eax,dword ptr [ebp-10h]
00AD079C push eax
00AD079D mov ecx,dword ptr [hires_now]
00AD07A0 push ecx
00AD07A1 call _allmul (0AE7D40h)
00AD07A6 mov dword ptr [hires_now],eax
00AD07A9 mov dword ptr [ebp-10h],edx

Apparently _allmul should be popping the stack but isn't (other similar functions in SDL_stdlib.c - _alldiv and whatnot - DO pop the stack).

A 'ret 10h' at the end of _allmul appears to do the trick

Wed, 15 May 2013 23:18:29 -0700There's no need to keep these private. If you extend SDLActivity, you should know what you're doing.
Sam Lantinga <slouken@libsdl.org> [Wed, 15 May 2013 23:18:29 -0700] rev 7179
There's no need to keep these private. If you extend SDLActivity, you should know what you're doing.

Wed, 15 May 2013 22:25:00 +0200Corrected internal function prototype.
Philipp Wiesemann <philipp.wiesemann@arcor.de> [Wed, 15 May 2013 22:25:00 +0200] rev 7178
Corrected internal function prototype.

Wed, 15 May 2013 22:24:23 +0200Corrected internal function prototype.
Philipp Wiesemann <philipp.wiesemann@arcor.de> [Wed, 15 May 2013 22:24:23 +0200] rev 7177
Corrected internal function prototype.

Wed, 15 May 2013 22:10:06 +0200Changed spelling for consistency.
Philipp Wiesemann <philipp.wiesemann@arcor.de> [Wed, 15 May 2013 22:10:06 +0200] rev 7176
Changed spelling for consistency.

Wed, 15 May 2013 22:00:28 +0200Fixed Doxygen warnings.
Philipp Wiesemann <philipp.wiesemann@arcor.de> [Wed, 15 May 2013 22:00:28 +0200] rev 7175
Fixed Doxygen warnings.

Mon, 13 May 2013 23:00:50 +0200Corrected spelling in header file.
Philipp Wiesemann <philipp.wiesemann@arcor.de> [Mon, 13 May 2013 23:00:50 +0200] rev 7174
Corrected spelling in header file.

Mon, 13 May 2013 22:45:06 +0200Inlined expression for consistency in render source.
Philipp Wiesemann <philipp.wiesemann@arcor.de> [Mon, 13 May 2013 22:45:06 +0200] rev 7173
Inlined expression for consistency in render source.

Sun, 12 May 2013 15:00:00 -0700Fix fuzzer/fuzzer tests on 64bit Linux; remove invalid negative SDL_Scancode test; disable failing surface/render test cases
Andreas Schiffler <aschiffler@ferzkopp.net> [Sun, 12 May 2013 15:00:00 -0700] rev 7172
Fix fuzzer/fuzzer tests on 64bit Linux; remove invalid negative SDL_Scancode test; disable failing surface/render test cases

Sun, 12 May 2013 14:25:38 +0200Fixed building on Visual Studio.
Philipp Wiesemann <philipp.wiesemann@arcor.de> [Sun, 12 May 2013 14:25:38 +0200] rev 7171
Fixed building on Visual Studio.

Buildbot