Sat, 08 Jun 2019 18:22:18 -0700Fixed bug 4294 - Audio: perform more validation on conversion request
Sam Lantinga [Sat, 08 Jun 2019 18:22:18 -0700] rev 12803
Fixed bug 4294 - Audio: perform more validation on conversion request

janisozaur

There are many cases which are not able to be handled by SDL's audio conversion routines, including too low (negative) rate, too high rate (impossible to allocate).

This patch aims to report such issues early and handle others in a graceful manner. The "INT32_MAX / RESAMPLER_SAMPLES_PER_ZERO_CROSSING" value is the conservative approach in terms of what can _technically_ be supported, but its value is 4'194'303, or just shy of 4.2MHz. I highly doubt any sane person would use such rates, especially in SDL2, so I would like to drive this limit further down, but would need some assistance to do that, as doing so would have to introduce an arbitrary value. Are you OK with such approach? What would a good value be? Wikipedia (https://en.wikipedia.org/wiki/High-resolution_audio) lists 96kHz as the highest sampling rate in use, even if I quadruple it for a good measure, to 384kHz it's still an order of magnitude lower than 4MHz.

Sat, 08 Jun 2019 18:07:58 -0700CVE-2019-7578: Fix a buffer overread in InitIMA_ADPCM
Sam Lantinga [Sat, 08 Jun 2019 18:07:58 -0700] rev 12802
CVE-2019-7578: Fix a buffer overread in InitIMA_ADPCM
If IMA ADPCM format chunk was too short, InitIMA_ADPCM() parsing it
could read past the end of chunk data. This patch fixes it.

CVE-2019-7578
https://bugzilla.libsdl.org/show_bug.cgi?id=4494

Signed-off-by: Petr Písař <ppisar@redhat.com>

Sat, 08 Jun 2019 18:02:09 -0700CVE-2019-7578: Fix a buffer overread in InitIMA_ADPCM SDL-1.2
Petr Písař [Sat, 08 Jun 2019 18:02:09 -0700] rev 12801
CVE-2019-7578: Fix a buffer overread in InitIMA_ADPCM
If IMA ADPCM format chunk was too short, InitIMA_ADPCM() parsing it
could read past the end of chunk data. This patch fixes it.

CVE-2019-7578
https://bugzilla.libsdl.org/show_bug.cgi?id=4494

Signed-off-by: Petr Písař <ppisar@redhat.com>

Sat, 08 Jun 2019 17:57:43 -0700CVE-2019-7572: Fix a buffer overread in IMA_ADPCM_nibble SDL-1.2
Petr Písař [Sat, 08 Jun 2019 17:57:43 -0700] rev 12800
CVE-2019-7572: Fix a buffer overread in IMA_ADPCM_nibble
If an IMA ADPCM block contained an initial index out of step table
range (loaded in IMA_ADPCM_decode()), IMA_ADPCM_nibble() blindly used
this bogus value and that lead to a buffer overread.

This patch fixes it by moving clamping the index value at the
beginning of IMA_ADPCM_nibble() function instead of the end after
an update.

CVE-2019-7572
https://bugzilla.libsdl.org/show_bug.cgi?id=4495

Signed-off-by: Petr Písař <ppisar@redhat.com>

Sat, 08 Jun 2019 17:43:23 -0700Fixed bug 4526 - replace SDL_RW* macros with functions for using in bindings
Sam Lantinga [Sat, 08 Jun 2019 17:43:23 -0700] rev 12799
Fixed bug 4526 - replace SDL_RW* macros with functions for using in bindings

ace

I got this bug in SDL_ttf:
https://bugzilla.libsdl.org/show_bug.cgi?id=4524
Sylvain proposed solution:
SDL_RWseek(RWops, 0, RW_SEEK_SET);

And it works, but i can use it my project, because it written in C# with SDL2-CS wrapper and there not export for macroses:
#define SDL_RWsize(ctx) (ctx)->size(ctx)
#define SDL_RWseek(ctx, offset, whence) (ctx)->seek(ctx, offset, whence)
#define SDL_RWtell(ctx) (ctx)->seek(ctx, 0, RW_SEEK_CUR)
#define SDL_RWread(ctx, ptr, size, n) (ctx)->read(ctx, ptr, size, n)
#define SDL_RWwrite(ctx, ptr, size, n) (ctx)->write(ctx, ptr, size, n)
#define SDL_RWclose(ctx) (ctx)->close(ctx)

Therefore, I suggest replacing this macros with functions so that they can be exported and used in bindings

Sat, 08 Jun 2019 15:10:20 -0700Fixed bug 4533 - Update ANGLE to load d3dcompiler_47.dll instead of d3dcompiler_46.dll
Sam Lantinga [Sat, 08 Jun 2019 15:10:20 -0700] rev 12798
Fixed bug 4533 - Update ANGLE to load d3dcompiler_47.dll instead of d3dcompiler_46.dll

msmshazan

Update ANGLE Libraries to support d3dcompiler_47.dll since chrome does not ship with d3dcompiler_46.dll and d3dcompiler_43.dll

Mon, 04 Mar 2019 12:16:43 -0500cocoa: Fix assert to use SDL_assert
Ethan Lee [Mon, 04 Mar 2019 12:16:43 -0500] rev 12797
cocoa: Fix assert to use SDL_assert

Sat, 08 Jun 2019 14:58:49 -0700Backed out Ben's chinese Xbox controller patch, as the generic catch-all for Xbox controllers should handle it.
Sam Lantinga [Sat, 08 Jun 2019 14:58:49 -0700] rev 12796
Backed out Ben's chinese Xbox controller patch, as the generic catch-all for Xbox controllers should handle it.

Sun, 17 Mar 2019 23:47:12 +0100Add mapping for Chinese-made Xbox Controller
Benjamin Valentin [Sun, 17 Mar 2019 23:47:12 +0100] rev 12795
Add mapping for Chinese-made Xbox Controller

This device is a copy of the Xbox Controller S and currently the one most sold
when shopping for a 'new' Xbox gamepad on eBay and AliExpress.
Except for the quirky USB ID id behaves just like a normal Xbox controller (when
ignoring the subpar build quality)

Sat, 08 Jun 2019 14:54:37 -0700Fixed bug 4557 - SDL_SIMDAlloc and *Free should be in the public interface
Sam Lantinga [Sat, 08 Jun 2019 14:54:37 -0700] rev 12794
Fixed bug 4557 - SDL_SIMDAlloc and *Free should be in the public interface

Martin Gerhardy

These functions are really useful and should get exposed imo.