Sun, 09 Feb 2014 01:49:01 -0800Fixed bug 2354 - [ES 2.0] SDL_RenderClear clears render target with wrong color
Sam Lantinga <slouken@libsdl.org> [Sun, 09 Feb 2014 01:49:01 -0800] rev 8192
Fixed bug 2354 - [ES 2.0] SDL_RenderClear clears render target with wrong color

ny00

SDL_RenderClear clears a render target with the wrong color, if the opengles2 renderer driver is used and the target texture's format is SDL_PIXELFORMAT_ARGB8888.

The bug is *not* reproduced if SDL_PIXELFORMAT_ABGR8888 is used as the texture format (the first from the renderer's list).
It is further not reproduced using any of the following renderer drivers: opengl, opengles (apparently powered by Gallium3D), software.
Finally, the correct color can be drawn using SDL_RenderFillRect (instead of SDL_RenderClear).

A few details about the current setup:
- OS: Ubuntu 12.04 for x86_64
- GPU: GeForce GTX 460
- GPU driver version: 331.20-0ubuntu1~xedgers~precise1 (from the xorg-edgers PPA)


---

Seth Williams

Sam,

It appears that the clear just needs to take the render target format into consideration.

Seth.

Fri, 07 Feb 2014 12:03:02 -0500Updated README-macosx.txt to note new minimum requirements, end of PowerPC.
Ryan C. Gordon <icculus@icculus.org> [Fri, 07 Feb 2014 12:03:02 -0500] rev 8191
Updated README-macosx.txt to note new minimum requirements, end of PowerPC.

Fri, 07 Feb 2014 11:55:13 -0500Make non-Clang compilers happy.
Ryan C. Gordon <icculus@icculus.org> [Fri, 07 Feb 2014 11:55:13 -0500] rev 8190
Make non-Clang compilers happy.

Fri, 07 Feb 2014 11:52:35 -0500Tell Clang's static analysis that SDL_assert() is an assertion handler.
Ryan C. Gordon <icculus@icculus.org> [Fri, 07 Feb 2014 11:52:35 -0500] rev 8189
Tell Clang's static analysis that SDL_assert() is an assertion handler.

This lets it know, for example, that when you do this...

SDL_assert(ptr != NULL);

...that (ptr) is definitely not NULL at this point in the program, for the
sake of static analysis. While a buggy program could definitely trigger this
assertion, Clang assumes your assertion check is covering it and won't
report possible NULL dereferences after this point.

Since SDL_assert might continue if the user clicks "ignore", without this
change Clang would notice you checked for NULL (meaning that NULL is a real
possibility here) and still wrote code outside of that test branch that
dereferences the pointer, and thus would always trigger false positives.

Static analysis is fun!

Fri, 07 Feb 2014 09:35:33 -0500slight adjustment to the hot plug test to allow it to be run with hap tics disabled
Edward Rudd <urkle@outoforder.cc> [Fri, 07 Feb 2014 09:35:33 -0500] rev 8188
slight adjustment to the hot plug test to allow it to be run with hap tics disabled

Fri, 07 Feb 2014 09:35:13 -0500ignore hot plugs in mac haptic layer IF hap tics hasn't been initialized.
Edward Rudd <urkle@outoforder.cc> [Fri, 07 Feb 2014 09:35:13 -0500] rev 8187
ignore hot plugs in mac haptic layer IF hap tics hasn't been initialized.

Thu, 06 Feb 2014 21:28:11 -0500Added DualShock 4 game controller config for Windows, Mac, and Linux.
Ryan C. Gordon <icculus@icculus.org> [Thu, 06 Feb 2014 21:28:11 -0500] rev 8186
Added DualShock 4 game controller config for Windows, Mac, and Linux.

Thu, 06 Feb 2014 21:26:41 -0500Fixed crash on Windows if haptic isn't initialized when controllers are added.
Ryan C. Gordon <icculus@icculus.org> [Thu, 06 Feb 2014 21:26:41 -0500] rev 8185
Fixed crash on Windows if haptic isn't initialized when controllers are added.

Thu, 06 Feb 2014 10:00:45 -0500Fixed a typo.
Ryan C. Gordon <icculus@icculus.org> [Thu, 06 Feb 2014 10:00:45 -0500] rev 8184
Fixed a typo.

Thu, 06 Feb 2014 09:35:44 -0500Fix device counting in HapticMouse and JoystickOpen routines. 0 is the first item in the list not the last
Edward Rudd <urkle@outoforder.cc> [Thu, 06 Feb 2014 09:35:44 -0500] rev 8183
Fix device counting in HapticMouse and JoystickOpen routines. 0 is the first item in the list not the last