Tue, 13 Oct 2009 06:45:02 +0000Only show the dynamic audio libraries if we'll be dynamically loading them SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Tue, 13 Oct 2009 06:45:02 +0000] rev 4328
Only show the dynamic audio libraries if we'll be dynamically loading them

Tue, 13 Oct 2009 05:20:09 +0000Simplify and improve dynamic library detection, taken from SDL_image SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Tue, 13 Oct 2009 05:20:09 +0000] rev 4327
Simplify and improve dynamic library detection, taken from SDL_image

Tue, 13 Oct 2009 04:23:34 +0000We don't need dlvsym() for ALSA anymore, yay! SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Tue, 13 Oct 2009 04:23:34 +0000] rev 4326
We don't need dlvsym() for ALSA anymore, yay!

Mon, 12 Oct 2009 23:21:19 +0000Merged fix from SDL 1.3 SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Mon, 12 Oct 2009 23:21:19 +0000] rev 4325
Merged fix from SDL 1.3

Mon, 12 Oct 2009 21:07:12 +0000Steven Noonan to sdl SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Mon, 12 Oct 2009 21:07:12 +0000] rev 4324
Steven Noonan to sdl

While trying to build the SDLMain.m included with SDL 1.2.14, with
#define SDL_USE_NIB_FILE 1:

/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:
In function '-[SDLMain fixMenu:withAppName:]':
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:122:
warning: 'sizeToFit' is deprecated (declared at
/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSMenu.h:281)
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:
In function 'main':
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:376:
warning: 'poseAsClass:' is deprecated (declared at
/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSObject.h:127)
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:376:
error: 'poseAsClass:' is unavailable (declared at
/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSObject.h:127)
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:377:
warning: passing argument 2 of 'NSApplicationMain' from incompatible
pointer type



Eric Wing to Sam

I don't have time today to look at this in detail, but the problem is definitely the poseAsClass: method.
This was deprecated in Obj-C 2.0 and not retained in 64-bit.

I've never used this method and it has always been limited to esoteric uses. I think this is why Apple wanted to dump it (among complicating some other things they do). I have read about others getting bit by this when migrating. Long story short, there really isn't a migration path for this method. The question that then must be asked is why are we using it (what does it accomplish), and then figure out the 'proper' way of accomplishing that.

Glancing at SDLMain.m, it's not obvious to me why it is there or what it is really accomplishing. My only speculation is that NSApplicationMain hardcodes something to look for NSApplication and a subclass (SDLApplication) fails for some reason (assuming that the original coder did this for good reason).

Three thoughts come to mind.
1) The Info.plist has properties to control things related to the startup class and nib.
NSPrincipalClass, NSMainNibFile

Maybe principle class needs to be SDLApplication and we can delete the poseAs

2) I was told that 10.6 introduced new APIs to make programatic NIB wrangling and avoidance easier. Unfortunately, I don't know the specifics.


3) Instead of subclassing NSApplication in SDLMain.m, maybe we can just add a category. It looks like the following is the only thing that is done (quick glance):

@interface SDLApplication : NSApplication
@end

@implementation SDLApplication
/* Invoked from the Quit menu item */
- (void)terminate:(id)sender
{
/* Post a SDL_QUIT event */
SDL_Event event;
event.type = SDL_QUIT;
SDL_PushEvent(&event);
}
@end


So instead, we change this to: (warning written in mail and untested)

@interface NSApplication (SDLApplication)
- (void) terminate:(id)sender;
@end

@implementation NSApplication (SDLApplication)
/* Invoked from the Quit menu item */
- (void)terminate:(id)sender
{
/* Post a SDL_QUIT event */
SDL_Event event;
event.type = SDL_QUIT;
SDL_PushEvent(&event);
}
@end


Then everywhere SDLApplication is used, we change it to NSApplication (and remove the poseAsClass line).

Perhaps you could ask the bug reporter to try this solution (#3).
And if that fails, maybe try #1.


-Eric


Steven Noonan to Sam

The suggested change (diff below) seems to work fine.

- Steven

Mon, 12 Oct 2009 09:32:55 +0000Joystick patch from FreeBSD ports system SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Mon, 12 Oct 2009 09:32:55 +0000] rev 4323
Joystick patch from FreeBSD ports system

Mon, 12 Oct 2009 08:58:12 +0000Forcibly disabled MMX mixers. SDL-1.2
Ryan C. Gordon <icculus@icculus.org> [Mon, 12 Oct 2009 08:58:12 +0000] rev 4322
Forcibly disabled MMX mixers.

Hopefully fixes Bugzilla #649.

Mon, 12 Oct 2009 08:18:36 +0000Whoops, need to convert from bits to bytes for frame size. SDL-1.2
Ryan C. Gordon <icculus@icculus.org> [Mon, 12 Oct 2009 08:18:36 +0000] rev 4321
Whoops, need to convert from bits to bytes for frame size.

Mon, 12 Oct 2009 08:06:40 +0000Corrected misuse of snd_pcm_writei() in ALSA driver. SDL-1.2
Ryan C. Gordon <icculus@icculus.org> [Mon, 12 Oct 2009 08:06:40 +0000] rev 4320
Corrected misuse of snd_pcm_writei() in ALSA driver.

Hopefully fixes Bugzilla #650.

Sat, 10 Oct 2009 15:10:06 +0000Added support for SDL_VIDEO_FULLSCREEN_DISPLAY, but mouse events need to be fixed up. SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Sat, 10 Oct 2009 15:10:06 +0000] rev 4319
Added support for SDL_VIDEO_FULLSCREEN_DISPLAY, but mouse events need to be fixed up.