Wed, 17 Apr 2013 01:38:59 -0700Fixed bug 1805 - Memory Leak issue in src/video/x11/edid-parse.c file
Sam Lantinga <slouken@libsdl.org> [Wed, 17 Apr 2013 01:38:59 -0700] rev 7072
Fixed bug 1805 - Memory Leak issue in src/video/x11/edid-parse.c file

Nitz

In Function,

MonitorInfo *
decode_edid (const uchar *edid)

In this function "info" is going out of scope and leaks the storage it points to, if the first if condition get true:
if (!decode_header (edid))
return NULL;

So while returning from this if statement there should be free for "info" pointer.

Wed, 17 Apr 2013 01:35:10 -0700Fixed bug 1804 - Memory leak issue in src/video/x11/SDL_x11mouse.c
Sam Lantinga <slouken@libsdl.org> [Wed, 17 Apr 2013 01:35:10 -0700] rev 7071
Fixed bug 1804 - Memory leak issue in src/video/x11/SDL_x11mouse.c

Nitz

In SDL_x11mouse.c file there is function named
static Cursor
X11_CreatePixmapCursor(SDL_Surface * surface, int hot_x, int hot_y)
{
// Some code

data_bits = SDL_calloc(1, surface->h * width_bytes);
mask_bits = SDL_calloc(1, surface->h * width_bytes);
if (!data_bits || !mask_bits) {
SDL_OutOfMemory();
return None;
}

// Some code

}

Here is the problem in if statement,
suppose if !data_bits is false and !mask_bits is true then,
data_bits will go out of scope and leaks the memory it points to.

Solution is that data_bits and mask_bits should be checked separately, not by using OR operator.

Wed, 17 Apr 2013 01:32:06 -0700Fixed bug 1802 - NULL pointer dereference in SDL_AllocRW() if out of memory.
Sam Lantinga <slouken@libsdl.org> [Wed, 17 Apr 2013 01:32:06 -0700] rev 7070
Fixed bug 1802 - NULL pointer dereference in SDL_AllocRW() if out of memory.

Philipp Wiesemann

There is a NULL pointer dereference in SDL_AllocRW() if the system is out of memory. The "type" field is always written. This may be fixed with an early return.

Or an else{} or not writing the field and using slower SDL_calloc().

This fault was recently introduced (http://hg.libsdl.org/SDL/rev/681820ca0e78).

Wed, 17 Apr 2013 00:56:53 -0700Fixed crash in Quartz gamma ramp code SDL-1.2
Sam Lantinga <slouken@libsdl.org> [Wed, 17 Apr 2013 00:56:53 -0700] rev 7069
Fixed crash in Quartz gamma ramp code

Tue, 16 Apr 2013 09:33:33 -0700BMP files don't contain alpha information in the palette, the fourth element is reserved and must be zero.
Sam Lantinga <slouken@libsdl.org> [Tue, 16 Apr 2013 09:33:33 -0700] rev 7068
BMP files don't contain alpha information in the palette, the fourth element is reserved and must be zero.

Tue, 16 Apr 2013 01:05:32 -0400Removed C++-style single-line comments from a public header (thanks, Martin!).
Ryan C. Gordon <icculus@icculus.org> [Tue, 16 Apr 2013 01:05:32 -0400] rev 7067
Removed C++-style single-line comments from a public header (thanks, Martin!).

Fixes Bugzilla #1803.

Tue, 16 Apr 2013 00:09:48 -0400Maybe actually fix compiler warning this time.
Ryan C. Gordon <icculus@icculus.org> [Tue, 16 Apr 2013 00:09:48 -0400] rev 7066
Maybe actually fix compiler warning this time.

Mon, 15 Apr 2013 22:49:23 -0400Fixed a compiler warning on Visual Studio.
Ryan C. Gordon <icculus@icculus.org> [Mon, 15 Apr 2013 22:49:23 -0400] rev 7065
Fixed a compiler warning on Visual Studio.

Sun, 14 Apr 2013 18:05:14 -0400Make the new SDL_RWops::hidden::unknown::data2 field a void*, not an int.
Ryan C. Gordon <icculus@icculus.org> [Sun, 14 Apr 2013 18:05:14 -0400] rev 7064
Make the new SDL_RWops::hidden::unknown::data2 field a void*, not an int.

Sat, 13 Apr 2013 20:43:32 -0400Added a data2 field to the SDL_RWops::hidden::unknown.
Ryan C. Gordon <icculus@icculus.org> [Sat, 13 Apr 2013 20:43:32 -0400] rev 7063
Added a data2 field to the SDL_RWops::hidden::unknown.

This shouldn't change the ABI, since this struct had space left in the union.