Mon, 02 Mar 2020 09:46:37 -0800Fixed compile warning
Sam Lantinga [Mon, 02 Mar 2020 09:46:37 -0800] rev 13571
Fixed compile warning

Mon, 02 Mar 2020 09:35:12 -0800ControllerList: add support for Victrix Pro FS w/ Touchpad for PS4
Sam Lantinga [Mon, 02 Mar 2020 09:35:12 -0800] rev 13570
ControllerList: add support for Victrix Pro FS w/ Touchpad for PS4

Mon, 02 Mar 2020 09:35:09 -0800Use SDL math functions in Steam Controller support
Sam Lantinga [Mon, 02 Mar 2020 09:35:09 -0800] rev 13569
Use SDL math functions in Steam Controller support

Mon, 02 Mar 2020 09:26:12 -0800Updated the HIDAPI Xbox One driver with support for Bluetooth Xbox One controllers
Sam Lantinga [Mon, 02 Mar 2020 09:26:12 -0800] rev 13568
Updated the HIDAPI Xbox One driver with support for Bluetooth Xbox One controllers

Mon, 02 Mar 2020 09:03:55 -0800Fixed build warnings
Sam Lantinga [Mon, 02 Mar 2020 09:03:55 -0800] rev 13567
Fixed build warnings

Sun, 01 Mar 2020 18:16:15 -0800Make sure hidapi is built for the release DMG
Sam Lantinga [Sun, 01 Mar 2020 18:16:15 -0800] rev 13566
Make sure hidapi is built for the release DMG

Sun, 01 Mar 2020 17:53:30 -0800We already have a hidapi implementation for Windows, we don't need libusb
Sam Lantinga [Sun, 01 Mar 2020 17:53:30 -0800] rev 13565
We already have a hidapi implementation for Windows, we don't need libusb

Sun, 01 Mar 2020 14:58:16 -0800Updated version to 2.0.12 for release candidate build
Sam Lantinga [Sun, 01 Mar 2020 14:58:16 -0800] rev 13564
Updated version to 2.0.12 for release candidate build

Sun, 01 Mar 2020 14:52:49 -0800Fixed bug 4996 - Mac: XBoxOne Bluetooth rumble isn't working
Sam Lantinga [Sun, 01 Mar 2020 14:52:49 -0800] rev 13563
Fixed bug 4996 - Mac: XBoxOne Bluetooth rumble isn't working

rofferom

I have an annoying issue on MacOS about XBoxOne Bluetooth rumble (Vendor: 0x045e, Product: 0x02fd).

When 360controller is installed, rumble is working correctly. However, Bluetooth rumble isn't working at all, with or without 360controller installed (although it is working with Chrome + https://html5gamepad.com).

I looked at the code, and it seems that XBox controllers are managed in MacOS in this file: SDL_hidapi_xbox360.c. The XBoxOne file is disabled for MacOS in SDL_hidjoystick_c.h.

The function HIDAPI_DriverXbox360_Rumble() is called correctly, and hid_write() returns no error.

I have tried a stupid test. I took the rumble packet from 360controller: https://github.com/360Controller/360Controller/blob/ec4e88eb2d2535e9b32561c702f42fb22b0a7f99/XBOBTFF/FFDriver.cpp#L620. With the patch I have attached, I manage to have rumble working on Bluetooth (with some stupid vibration level, but it proves it can if the packet is changed).

But it breaks the USB rumble with 360controller. A comment in the function makes an explicit reference to 360controller, I think that's why I have broken this specific usecase.

I don't know what is the correct way to fix this, but it seems that the current implementation has a missing case for Bluetooth support.


Note that I also tested master this morning, and I have another issue:
if (!device->ffservice) {
return SDL_Unsupported();
}

test fails in DARWIN_JoystickRumble(). This test has been done quickly, I'm not totaly confident about its accuracy.

Sun, 01 Mar 2020 13:01:53 -0800mac: Fix gamepad detection
Romain Roffé [Sun, 01 Mar 2020 13:01:53 -0800] rev 13562
mac: Fix gamepad detection