Wed, 25 Jan 2006 18:11:56 +0000SDL_GetVideoMode, part 3: pixel count compare was failing when only 1 video mode was present
Patrice Mandin [Wed, 25 Jan 2006 18:11:56 +0000] rev 1266
SDL_GetVideoMode, part 3: pixel count compare was failing when only 1 video mode was present

Wed, 25 Jan 2006 07:04:02 +0000Date: Mon, 22 Sep 2003 23:31:54 -0700 (PDT)
Sam Lantinga [Wed, 25 Jan 2006 07:04:02 +0000] rev 1265
Date: Mon, 22 Sep 2003 23:31:54 -0700 (PDT)
From: Rob Neff
Subject: [SDL] testgl.c minor bug fix for fullscreen mode


if ( strcmp(argv[1], "-fullscreen") == 0 ) {


if ( strcmp(argv[i], "-fullscreen") == 0 ) {

Minor bug, but might help someone else out who is trying to pass
the command-line params -logo -fullscreen like I was! :)

Wed, 25 Jan 2006 07:00:40 +0000Date: Sun, 21 Sep 2003 19:52:42 -0600
Sam Lantinga [Wed, 25 Jan 2006 07:00:40 +0000] rev 1264
Date: Sun, 21 Sep 2003 19:52:42 -0600
From: Tyler Montbriand <>
Subject: Re: [SDL] Hardware buttons on pocket pc

I found it! :)

It has to do with the UNICODE translation code, in SDL_dibevents.c, in the
'#ifdef NO_GETKEYBOARDSTATE' block in DIB_HandleMessage(). The error
handling is a little... aggressive. If it can't translate from unicode, it
wipes out the virtual keycode.

Wed, 25 Jan 2006 06:53:50 +0000*** empty log message ***
Sam Lantinga [Wed, 25 Jan 2006 06:53:50 +0000] rev 1263
*** empty log message ***

Wed, 25 Jan 2006 06:12:57 +0000Hopefully the X servers have been fixed (in 5 years) :)
Sam Lantinga [Wed, 25 Jan 2006 06:12:57 +0000] rev 1262
Hopefully the X servers have been fixed (in 5 years) :)

Wed, 25 Jan 2006 06:04:21 +0000Date: Thu, 04 Sep 2003 02:12:35 +0200
Sam Lantinga [Wed, 25 Jan 2006 06:04:21 +0000] rev 1261
Date: Thu, 04 Sep 2003 02:12:35 +0200
From: Ignacio Casta´┐Żo <>

It would be nice to add the following lines:

*value = 0;
*value = 1;

in wincommon\SDL_wingl.c int the function WIN_GL_GetAttribute at line
484, so that it returns the correct values when arb_pixel_format is not

Tue, 24 Jan 2006 07:20:18 +0000Date: 10 Jun 2003 15:30:59 -0400
Sam Lantinga [Tue, 24 Jan 2006 07:20:18 +0000] rev 1260
Date: 10 Jun 2003 15:30:59 -0400
From: Mike Shal
Subject: [SDL] Bug in SDL_wave.c?

Hey everyone, I'm not sure if this is a bug in SDL, or if I just have
incorrect WAV files. The problem I'm having is loading multiple
concatenated WAVs from SDL_LoadWAV_RW. Some WAV files put comments at
the end of the file (which may be bad form), and SDL doesn't skip past
them when reading from the RWops. So the next WAV I try to load will
start at the comment section of the previous WAV, which obviously
doesn't work. If anyone else is having this problem, one quick fix you
can do is run sox on the bad WAVs, which strips out all of the comment

$ sox sound.wav tmp.wav
$ mv -f tmp.wav sound.wav

The other fix is to patch SDL_wave.c, which is included with this email.
(Assuming I made the patch correctly :). All it does is calculate how
much remaining space there is in the WAV file after the data chunk, and
does SDL_RWseek to skip it. I don't think it should interfere with
anything else, but if someone could check it that would be nice :). If
the bug is really with SDL and not with my WAVs, can someone work this
into the next version of SDL? Thanks,

-Mike Shal

Tue, 24 Jan 2006 06:36:43 +0000te: Thu, 17 Apr 2003 11:25:26 -0700
Sam Lantinga [Tue, 24 Jan 2006 06:36:43 +0000] rev 1259
te: Thu, 17 Apr 2003 11:25:26 -0700
From: "Jim"
Subject: [SDL] Frame buffer patches...

Would seem that GCC 3.2.2 promotes all signed values to unsigned if any single vlaue is unsigned in an expression...

for instance when calculating an elo touch position....evertyhign is an (int) except for cach_vinfo.xres which is unsigned. THerefore if y
ou reverse the SDL_ELO_MIN_X and SDL_ELO_MAX_X values the resulging negative value pegs the expression to it's max. Attached it the accumu
lated patch to typecast the unsigned values to (int)

- *dx = (cache_vinfo.xres - (cache_vinfo.xres * (input_x - ELO_MIN_X)) / width);

+ *dx = ((int)cache_vinfo.xres - ((int)cache_vinfo.xres * (input_x - ELO_MIN_X)) / width);

and also to provide quite failure to operations which have the screen currently locked...

The touch screen I'm using the original values were exactly opposite of any position I touched on the screen - evaluating the math the expr
ession SHOULD have handled reversing the min and max values - and after casting the unsigned .xres and .yres to a signed int - worked well.


Fri, 20 Jan 2006 13:07:25 +0000Date: Thu, 19 Jan 2006 20:02:29 +0200
Sam Lantinga [Fri, 20 Jan 2006 13:07:25 +0000] rev 1258
Date: Thu, 19 Jan 2006 20:02:29 +0200
From: Vassilis Virvilis <>
Subject: [SDL] Request: Please reconsider adding tag in SDL_Event


Patch in question:

--- include/SDL_events.h 20 Aug 2004 18:57:01 -0000 1.11
+++ include/SDL_events.h 19 Jan 2006 17:35:09 -0000
@@ -214,7 +214,7 @@
} SDL_SysWMEvent;

/* General event structure */
-typedef union {
+typedef union SDL_Event {
Uint8 type;
SDL_ActiveEvent active;
SDL_KeyboardEvent key;

1) Allows forward declaration of the SDL_Event union in C++. Please
note that in plain C it is possible to forward declare it.

2) Forward declaration is good because it allows encapsulation. It hides
the specific implementation and does not necessarily exposes SDL staff
to my appication's namespace

3) It can't harm plain C because tags are living in a different namespace
than typenames

4) It is already done like this in other places in SDL. Check for example
SDL_KeySym, and SDL_.*Event structures.

5) Right now I have to include SDL/event.h from a C++ header file. See 2)

Thu, 19 Jan 2006 21:28:52 +0000[PATCH] SDL_GetVideoMode() does not find best mode, part 2
Patrice Mandin [Thu, 19 Jan 2006 21:28:52 +0000] rev 1257
[PATCH] SDL_GetVideoMode() does not find best mode, part 2

Following commit 1.51, I come accross a problem when SDL must choose between
several video modes that could suit the one asked.

If I ask 320x240 with this list:
768x480 768x240 640x400 640x200 384x480 384x240 320x400 320x200

The smallest selectables modes are 384x240 and 320x400. And SDL choose the later
in this list, but 384x240 is more suitable. So I added a check to compare
the pixel count (surface) of modes, and select the one which has the smallest
pixel count.

In my example, 384x240 has 92160 pixels, and 320x400 has 128000 pixels. So now
SDL will choose 384x240 for the asked 320x240 mode.