src/video/android/SDL_androidgl.c
author Sylvain Becker <sylvain.becker@gmail.com>
Thu, 03 Jan 2019 23:22:50 +0100
changeset 12499 e6130a4cca7a
parent 11811 5d94cb6b24d3
child 12503 806492103856
permissions -rw-r--r--
Android: concurrency issue with egl_surface EGL_BAD_SURFACE - (bug 4142)

Occurs when application goes to background:
- Java activity is destroying SurfaceView holder and "egl_surface" (in onNativeSurfaceDestroyed())
- While native thread is in Android_GLES_SwapWindow(), prepared to call SDL_EGL_SwapBuffers()

The error is "call to eglSwapBuffers failed, reporting an error of EGL_BAD_SURFACE"

It an be reproduced easily by adding a SDL_Delay(100) at the begining of SDL_EGL_SwapBuffers(),
and putting the application into background.
     1 /*
     2   Simple DirectMedia Layer
     3   Copyright (C) 1997-2018 Sam Lantinga <slouken@libsdl.org>
     4 
     5   This software is provided 'as-is', without any express or implied
     6   warranty.  In no event will the authors be held liable for any damages
     7   arising from the use of this software.
     8 
     9   Permission is granted to anyone to use this software for any purpose,
    10   including commercial applications, and to alter it and redistribute it
    11   freely, subject to the following restrictions:
    12 
    13   1. The origin of this software must not be misrepresented; you must not
    14      claim that you wrote the original software. If you use this software
    15      in a product, an acknowledgment in the product documentation would be
    16      appreciated but is not required.
    17   2. Altered source versions must be plainly marked as such, and must not be
    18      misrepresented as being the original software.
    19   3. This notice may not be removed or altered from any source distribution.
    20 */
    21 #include "../../SDL_internal.h"
    22 
    23 #if SDL_VIDEO_DRIVER_ANDROID
    24 
    25 /* Android SDL video driver implementation */
    26 
    27 #include "SDL_video.h"
    28 #include "../SDL_egl_c.h"
    29 #include "SDL_androidwindow.h"
    30 
    31 #include "SDL_androidvideo.h"
    32 #include "SDL_androidgl.h"
    33 #include "../../core/android/SDL_android.h"
    34 
    35 #include <android/log.h>
    36 
    37 #include <dlfcn.h>
    38 
    39 SDL_EGL_CreateContext_impl(Android)
    40 SDL_EGL_MakeCurrent_impl(Android)
    41 
    42 int
    43 Android_GLES_SwapWindow(_THIS, SDL_Window * window)
    44 {
    45     int retval;
    46 
    47     SDL_LockMutex(Android_ActivityMutex);
    48 
    49     /* The following two calls existed in the original Java code
    50      * If you happen to have a device that's affected by their removal,
    51      * please report to Bugzilla. -- Gabriel
    52      */
    53 
    54     /*_this->egl_data->eglWaitNative(EGL_CORE_NATIVE_ENGINE);
    55     _this->egl_data->eglWaitGL();*/
    56     retval = SDL_EGL_SwapBuffers(_this, ((SDL_WindowData *) window->driverdata)->egl_surface);
    57 
    58     SDL_UnlockMutex(Android_ActivityMutex);
    59 
    60     return retval;
    61 }
    62 
    63 int
    64 Android_GLES_LoadLibrary(_THIS, const char *path) {
    65     return SDL_EGL_LoadLibrary(_this, path, (NativeDisplayType) 0, 0);
    66 }
    67 
    68 #endif /* SDL_VIDEO_DRIVER_ANDROID */
    69 
    70 /* vi: set ts=4 sw=4 expandtab: */