author Sam Lantinga <>
Mon, 02 Jun 2003 14:50:22 +0000
changeset 632 85e104fe14c2
parent 433 706de3956894
permissions -rw-r--r--
Date: Sun, 1 Jun 2003 15:38:45 -0700 (PDT)
From: Jeff Brown <>
Subject: [patch] SDL-1.2.5 + FreeBSD joystick axes, hat fixes

Hello again! When I sent in some SDL fixes last December, I found out
they'd already been fixed in the CVS version. This time, I checked the
repository before bugging you. =)

I'm using SDL-1.2.5 on a FreeBSD 4.6.2-RELEASE system, and in the course
of getting my multi-analog-axis USB controller (with a hat switch!)
working with d2x-sdl -- the SDL port of the Descent 2 engine -- I came
across a few problems:

1) The second analog stick is reported as a slider in one direction, and
"Rz" in the other. SDL was ignoring the Rz axis, so I added Rx/Ry/Rz to
the set of things SDL considers to be axes.

2) After the above change, the set of JOYAXE_* axes for my gamepad was
{0,1,3,7}; however, d2x-sdl expects the axes to be contiguously numbered
from 0, which seems like a pretty reasonable expectation, rather than
having to scan the entire space of axes that SDL may or may not have.
So, I added a table lookup which maps the JOYAXE_* axis numbers to 0,1,...
in the order they're detected by SDL_SYS_JoystickOpen(), when reporting
them to the application. I also added a function "usage_to_joyaxe()"
which maps the USB HUG_* usage values to JOYAXE_values, since the repeated
case statements testing for HUG_* were getting out of hand.

3) The BSD joystick driver had no hat support, so I added it. It looks
like our USB library can only support one hat switch per device, which
makes life easy.

The patch against SDL-1.2.5 which implements these changes is at:

After applying, SDL's "testjoystick" reports all activity from my gamepad
correctly, and d2x works too (though it needed some other fixes).

Moving on...

There is also a problem with slightly different USBHID library interfaces
on different versions of FreeBSD. I wasn't going to mention this since the
FreeBSD port for SDL-1.2.5 (and not SDL itself) was doing the FreeBSD
version-specific patching, so I e-mailed the port maintainer with this
change. However, I see that you've incorporated the FreeBSD
version-checking stuff into the CVS version of SDL, so now it's relevant
for you too.

The problem is, the FreeBSD #if tests don't work right for FreeBSD
4.6.2-RELEASE. There may be other versions with this problem, but I've
only tested 4.6.2-R. The following patch against your latest CVS version
fixes this:

--- SDL_sysjoystick.c-1.16 Tue Apr 15 09:02:08 2003
+++ SDL_sysjoystick.c Sun Jun 1 15:10:28 2003
@@ -420,6 +420,8 @@
# else
len = hid_report_size(rd, repinfo[repind].kind, r->rid);
# endif
+# elif (__FreeBSD_version == 460002)
+ len = hid_report_size(rd, r->rid, repinfo[repind].kind);
# else
len = hid_report_size(rd, repinfo[repind].kind, &r->rid);

I hope this is all useful to you. I've been getting myself dizzy playing
Descent 2 with it, all morning!

-Jeff Brown

P.S. My USB controller is a Thrustmaster Firestorm Dual Analog 2. That's
probably irrelevant, but I threw it in for completeness.
     1  ========================
     2   Using SDL with PicoGUI
     3  ========================
     5 - Originally contributed by Micah Dowty <>
     7 PicoGUI is a scalable GUI system with a unique architecture, primarily focused
     8 on scalability to various embedded systems. You can find more information
     9 including a FAQ at
    11 To use the patch:
    13   1. When compiling, add the "--enable-video-picogui" switch to ./configure
    15   2. When running your program, ensure that the picogui driver for SDL
    16      is in use by setting the SDL_VIDEODRIVER environment variable 
    17      to "picogui".
    19   3. The program must also be linked to the C client library for PicoGUI
    20      ( If the program is being compiled with a patched SDL 
    21      installed this should be done automatically. If you want to use an
    22      existing binary with PicoGUI, you can set the LD_PRELOAD environment
    23      variable to the path of your file.
    25 Capabilities:
    27   So far only basic functionality is provided on true color (linear16/24/32)
    28   devices. Accessing a memory mapped bitmap, updating the display, and handling
    29   mouse/keyboard input. This functionality has been tested with several
    30   applications, including mplayer, Xine, sldroids, and Abuse.
    32 TODO list:
    34   - YUV overlays will be helpful for watching video on set top boxes or other
    35     embedded devices that have some graphics acceleration hardware
    37   - Account for rotated bitmap storage in pgserver
    39   - Support for hiding or changing the cursor
    41   - The display should be centered when the SDL application is smaller
    42     than the PicoGUI panel
    44   - Fullscreen or any other special modes
    46   - Support for indexed and grayscale modes
    48   - Probably much more...
    50 --- The End ---