author David Ludwig <>
Tue, 17 Mar 2020 17:34:24 -0400
changeset 13646 784ce9766fb9
parent 11605 b914622c734e
permissions -rw-r--r--
Fix for Bug 5034 - Replugging in a controller crashes on macOS in SDL 2.0.12

This is a multi-part fix, and is the 2nd attempt at a fix for Bug 5034. Here
are the problems being addressed:

1. On macOS 10.14.x and earlier, trying to call IOHIDDeviceUnscheduleFromRunLoop
without a prior, paired call to IOHIDDeviceScheduleWithRunLoop, appears to
lead to a crash. A per-device flag has been added to make sure that these
calls are paired.
2. DARWIN_JoystickDetect was free'ing its SDL_joystick's hwdata field
(via FreeDevice) without setting it to NULL, and DARWIN_JoystickRumble wasn't
checking for a NULL hwdata. FreeDevice will now set hwdata to NULL and
DARWIN_JoystickRumble will check for a NULL hwdata.
     1 if (NOT EXISTS "@CMAKE_BINARY_DIR@/install_manifest.txt")
     2     message(FATAL_ERROR "Cannot find install manifest: \"@CMAKE_BINARY_DIR@/install_manifest.txt\"")
     3 endif(NOT EXISTS "@CMAKE_BINARY_DIR@/install_manifest.txt")
     5 file(READ "@CMAKE_BINARY_DIR@/install_manifest.txt" files)
     6 string(REGEX REPLACE "\n" ";" files "${files}")
     7 foreach (file ${files})
     8     message(STATUS "Uninstalling \"$ENV{DESTDIR}${file}\"")
     9     execute_process(
    10         COMMAND @CMAKE_COMMAND@ -E remove "$ENV{DESTDIR}${file}"
    11         OUTPUT_VARIABLE rm_out
    12         RESULT_VARIABLE rm_retval
    13     )
    14     if(NOT ${rm_retval} EQUAL 0)
    15         message(FATAL_ERROR "Problem when removing \"$ENV{DESTDIR}${file}\"")
    16     endif (NOT ${rm_retval} EQUAL 0)
    17 endforeach(file)