sdl2-config.in
author Sam Lantinga
Sat, 08 Jun 2019 18:22:18 -0700
changeset 12803 70d338e248c8
parent 7876 d6373384b5ce
child 13729 89a457159af4
permissions -rw-r--r--
Fixed bug 4294 - Audio: perform more validation on conversion request

janisozaur

There are many cases which are not able to be handled by SDL's audio conversion routines, including too low (negative) rate, too high rate (impossible to allocate).

This patch aims to report such issues early and handle others in a graceful manner. The "INT32_MAX / RESAMPLER_SAMPLES_PER_ZERO_CROSSING" value is the conservative approach in terms of what can _technically_ be supported, but its value is 4'194'303, or just shy of 4.2MHz. I highly doubt any sane person would use such rates, especially in SDL2, so I would like to drive this limit further down, but would need some assistance to do that, as doing so would have to introduce an arbitrary value. Are you OK with such approach? What would a good value be? Wikipedia (https://en.wikipedia.org/wiki/High-resolution_audio) lists 96kHz as the highest sampling rate in use, even if I quadruple it for a good measure, to 384kHz it's still an order of magnitude lower than 4MHz.
     1 #!/bin/sh
     2 
     3 prefix=@prefix@
     4 exec_prefix=@exec_prefix@
     5 exec_prefix_set=no
     6 libdir=@libdir@
     7 
     8 @ENABLE_STATIC_FALSE@usage="\
     9 @ENABLE_STATIC_FALSE@Usage: $0 [--prefix[=DIR]] [--exec-prefix[=DIR]] [--version] [--cflags] [--libs]"
    10 @ENABLE_STATIC_TRUE@usage="\
    11 @ENABLE_STATIC_TRUE@Usage: $0 [--prefix[=DIR]] [--exec-prefix[=DIR]] [--version] [--cflags] [--libs] [--static-libs]"
    12 
    13 if test $# -eq 0; then
    14       echo "${usage}" 1>&2
    15       exit 1
    16 fi
    17 
    18 while test $# -gt 0; do
    19   case "$1" in
    20   -*=*) optarg=`echo "$1" | sed 's/[-_a-zA-Z0-9]*=//'` ;;
    21   *) optarg= ;;
    22   esac
    23 
    24   case $1 in
    25     --prefix=*)
    26       prefix=$optarg
    27       if test $exec_prefix_set = no ; then
    28         exec_prefix=$optarg
    29       fi
    30       ;;
    31     --prefix)
    32       echo $prefix
    33       ;;
    34     --exec-prefix=*)
    35       exec_prefix=$optarg
    36       exec_prefix_set=yes
    37       ;;
    38     --exec-prefix)
    39       echo $exec_prefix
    40       ;;
    41     --version)
    42       echo @SDL_VERSION@
    43       ;;
    44     --cflags)
    45       echo -I@includedir@/SDL2 @SDL_CFLAGS@
    46       ;;
    47 @ENABLE_SHARED_TRUE@    --libs)
    48 @ENABLE_SHARED_TRUE@      echo -L@libdir@ @SDL_RLD_FLAGS@ @SDL_LIBS@
    49 @ENABLE_SHARED_TRUE@      ;;
    50 @ENABLE_STATIC_TRUE@@ENABLE_SHARED_TRUE@    --static-libs)
    51 @ENABLE_STATIC_TRUE@@ENABLE_SHARED_FALSE@    --libs|--static-libs)
    52 @ENABLE_STATIC_TRUE@      echo -L@libdir@ @SDL_RLD_FLAGS@ @SDL_STATIC_LIBS@
    53 @ENABLE_STATIC_TRUE@      ;;
    54     *)
    55       echo "${usage}" 1>&2
    56       exit 1
    57       ;;
    58   esac
    59   shift
    60 done