src/video/cocoa/SDL_cocoaopengl.m
author Ryan C. Gordon <icculus@icculus.org>
Sun, 31 Mar 2013 12:48:50 -0400
changeset 7037 3fedf1f25b94
parent 6952 d2e309e7f77c
child 7085 152cc7ddfa57
permissions -rw-r--r--
Make SDL_SetError and friends unconditionally return -1.

This lets us change things like this...

if (Failed) {
SDL_SetError("We failed");
return -1;
}

...into this...

if (Failed) {
return SDL_SetError("We failed");
}


Fixes Bugzilla #1778.
     1 /*
     2   Simple DirectMedia Layer
     3   Copyright (C) 1997-2013 Sam Lantinga <slouken@libsdl.org>
     4 
     5   This software is provided 'as-is', without any express or implied
     6   warranty.  In no event will the authors be held liable for any damages
     7   arising from the use of this software.
     8 
     9   Permission is granted to anyone to use this software for any purpose,
    10   including commercial applications, and to alter it and redistribute it
    11   freely, subject to the following restrictions:
    12 
    13   1. The origin of this software must not be misrepresented; you must not
    14      claim that you wrote the original software. If you use this software
    15      in a product, an acknowledgment in the product documentation would be
    16      appreciated but is not required.
    17   2. Altered source versions must be plainly marked as such, and must not be
    18      misrepresented as being the original software.
    19   3. This notice may not be removed or altered from any source distribution.
    20 */
    21 #include "SDL_config.h"
    22 
    23 /* NSOpenGL implementation of SDL OpenGL support */
    24 
    25 #if SDL_VIDEO_OPENGL_CGL
    26 #include "SDL_cocoavideo.h"
    27 
    28 #include <OpenGL/CGLTypes.h>
    29 #include <OpenGL/OpenGL.h>
    30 #include <OpenGL/CGLRenderers.h>
    31 
    32 #include "SDL_loadso.h"
    33 #include "SDL_opengl.h"
    34 
    35 #define DEFAULT_OPENGL  "/System/Library/Frameworks/OpenGL.framework/Libraries/libGL.dylib"
    36 
    37 
    38 #ifndef kCGLPFAOpenGLProfile
    39 #define kCGLPFAOpenGLProfile 99
    40 #endif
    41 #ifndef kCGLOGLPVersion_Legacy
    42 #define kCGLOGLPVersion_Legacy 0x1000
    43 #endif
    44 #ifndef kCGLOGLPVersion_3_2_Core
    45 #define kCGLOGLPVersion_3_2_Core 0x3200
    46 #endif
    47 
    48 
    49 int
    50 Cocoa_GL_LoadLibrary(_THIS, const char *path)
    51 {
    52     /* Load the OpenGL library */
    53     if (path == NULL) {
    54         path = SDL_getenv("SDL_OPENGL_LIBRARY");
    55     }
    56     if (path == NULL) {
    57         path = DEFAULT_OPENGL;
    58     }
    59     _this->gl_config.dll_handle = SDL_LoadObject(path);
    60     if (!_this->gl_config.dll_handle) {
    61         return -1;
    62     }
    63     SDL_strlcpy(_this->gl_config.driver_path, path,
    64                 SDL_arraysize(_this->gl_config.driver_path));
    65     return 0;
    66 }
    67 
    68 void *
    69 Cocoa_GL_GetProcAddress(_THIS, const char *proc)
    70 {
    71     return SDL_LoadFunction(_this->gl_config.dll_handle, proc);
    72 }
    73 
    74 void
    75 Cocoa_GL_UnloadLibrary(_THIS)
    76 {
    77     SDL_UnloadObject(_this->gl_config.dll_handle);
    78     _this->gl_config.dll_handle = NULL;
    79 }
    80 
    81 SDL_GLContext
    82 Cocoa_GL_CreateContext(_THIS, SDL_Window * window)
    83 {
    84     const int wantver = (_this->gl_config.major_version << 8) |
    85                         (_this->gl_config.minor_version);
    86     SDL_VideoData *data = (SDL_VideoData *) _this->driverdata;
    87     NSAutoreleasePool *pool;
    88     SDL_VideoDisplay *display = SDL_GetDisplayForWindow(window);
    89     SDL_DisplayData *displaydata = (SDL_DisplayData *)display->driverdata;
    90     NSOpenGLPixelFormatAttribute attr[32];
    91     NSOpenGLPixelFormat *fmt;
    92     NSOpenGLContext *context;
    93     int i = 0;
    94 
    95     if (_this->gl_config.profile_mask == SDL_GL_CONTEXT_PROFILE_ES) {
    96         SDL_SetError ("OpenGL ES not supported on this platform");
    97         return NULL;
    98     }
    99 
   100     /* Sadly, we'll have to update this as life progresses, since we need to
   101        set an enum for context profiles, not a context version number */
   102     if (wantver > 0x0302) {
   103         SDL_SetError ("OpenGL > 3.2 is not supported on this platform");
   104         return NULL;
   105     }
   106 
   107     pool = [[NSAutoreleasePool alloc] init];
   108 
   109     /* specify a profile if we're on Lion (10.7) or later. */
   110     if (data->osversion >= 0x1070) {
   111         NSOpenGLPixelFormatAttribute profile = kCGLOGLPVersion_Legacy;
   112         if (_this->gl_config.profile_mask == SDL_GL_CONTEXT_PROFILE_CORE) {
   113             if (wantver == 0x0302) {
   114                 profile = kCGLOGLPVersion_3_2_Core;
   115             }
   116         }
   117         attr[i++] = kCGLPFAOpenGLProfile;
   118         attr[i++] = profile;
   119     }
   120 
   121 #ifndef FULLSCREEN_TOGGLEABLE
   122     if (window->flags & SDL_WINDOW_FULLSCREEN) {
   123         attr[i++] = NSOpenGLPFAFullScreen;
   124     }
   125 #endif
   126 
   127     attr[i++] = NSOpenGLPFAColorSize;
   128     attr[i++] = SDL_BYTESPERPIXEL(display->current_mode.format)*8;
   129 
   130     attr[i++] = NSOpenGLPFADepthSize;
   131     attr[i++] = _this->gl_config.depth_size;
   132 
   133     if (_this->gl_config.double_buffer) {
   134         attr[i++] = NSOpenGLPFADoubleBuffer;
   135     }
   136 
   137     if (_this->gl_config.stereo) {
   138         attr[i++] = NSOpenGLPFAStereo;
   139     }
   140 
   141     if (_this->gl_config.stencil_size) {
   142         attr[i++] = NSOpenGLPFAStencilSize;
   143         attr[i++] = _this->gl_config.stencil_size;
   144     }
   145 
   146     if ((_this->gl_config.accum_red_size +
   147          _this->gl_config.accum_green_size +
   148          _this->gl_config.accum_blue_size +
   149          _this->gl_config.accum_alpha_size) > 0) {
   150         attr[i++] = NSOpenGLPFAAccumSize;
   151         attr[i++] = _this->gl_config.accum_red_size + _this->gl_config.accum_green_size + _this->gl_config.accum_blue_size + _this->gl_config.accum_alpha_size;
   152     }
   153 
   154     if (_this->gl_config.multisamplebuffers) {
   155         attr[i++] = NSOpenGLPFASampleBuffers;
   156         attr[i++] = _this->gl_config.multisamplebuffers;
   157     }
   158 
   159     if (_this->gl_config.multisamplesamples) {
   160         attr[i++] = NSOpenGLPFASamples;
   161         attr[i++] = _this->gl_config.multisamplesamples;
   162         attr[i++] = NSOpenGLPFANoRecovery;
   163     }
   164 
   165     if (_this->gl_config.accelerated >= 0) {
   166         if (_this->gl_config.accelerated) {
   167             attr[i++] = NSOpenGLPFAAccelerated;
   168         } else {
   169             attr[i++] = NSOpenGLPFARendererID;
   170             attr[i++] = kCGLRendererGenericFloatID;
   171         }
   172     }
   173 
   174     attr[i++] = NSOpenGLPFAScreenMask;
   175     attr[i++] = CGDisplayIDToOpenGLDisplayMask(displaydata->display);
   176     attr[i] = 0;
   177 
   178     fmt = [[NSOpenGLPixelFormat alloc] initWithAttributes:attr];
   179     if (fmt == nil) {
   180         SDL_SetError ("Failed creating OpenGL pixel format");
   181         [pool release];
   182         return NULL;
   183     }
   184 
   185     context = [[NSOpenGLContext alloc] initWithFormat:fmt shareContext:nil];
   186 
   187     [fmt release];
   188 
   189     if (context == nil) {
   190         SDL_SetError ("Failed creating OpenGL context");
   191         [pool release];
   192         return NULL;
   193     }
   194 
   195     /*
   196      * Wisdom from Apple engineer in reference to UT2003's OpenGL performance:
   197      *  "You are blowing a couple of the internal OpenGL function caches. This
   198      *  appears to be happening in the VAO case.  You can tell OpenGL to up
   199      *  the cache size by issuing the following calls right after you create
   200      *  the OpenGL context.  The default cache size is 16."    --ryan.
   201      */
   202 
   203     #ifndef GLI_ARRAY_FUNC_CACHE_MAX
   204     #define GLI_ARRAY_FUNC_CACHE_MAX 284
   205     #endif
   206 
   207     #ifndef GLI_SUBMIT_FUNC_CACHE_MAX
   208     #define GLI_SUBMIT_FUNC_CACHE_MAX 280
   209     #endif
   210 
   211     {
   212         GLint cache_max = 64;
   213         CGLContextObj ctx = [context CGLContextObj];
   214         CGLSetParameter (ctx, GLI_SUBMIT_FUNC_CACHE_MAX, &cache_max);
   215         CGLSetParameter (ctx, GLI_ARRAY_FUNC_CACHE_MAX, &cache_max);
   216     }
   217 
   218     /* End Wisdom from Apple Engineer section. --ryan. */
   219 
   220     [pool release];
   221 
   222     if ( Cocoa_GL_MakeCurrent(_this, window, context) < 0 ) {
   223         Cocoa_GL_DeleteContext(_this, context);
   224         return NULL;
   225     }
   226 
   227     return context;
   228 }
   229 
   230 int
   231 Cocoa_GL_MakeCurrent(_THIS, SDL_Window * window, SDL_GLContext context)
   232 {
   233     NSAutoreleasePool *pool;
   234 
   235     pool = [[NSAutoreleasePool alloc] init];
   236 
   237     if (context) {
   238         SDL_WindowData *windowdata = (SDL_WindowData *)window->driverdata;
   239         NSOpenGLContext *nscontext = (NSOpenGLContext *)context;
   240 
   241         if (window->flags & SDL_WINDOW_SHOWN) {
   242 #ifndef FULLSCREEN_TOGGLEABLE
   243             if (window->flags & SDL_WINDOW_FULLSCREEN) {
   244                 [nscontext setFullScreen];
   245             } else
   246 #endif
   247             {
   248                 [nscontext setView:[windowdata->nswindow contentView]];
   249                 [nscontext update];
   250             }
   251         }
   252         [nscontext makeCurrentContext];
   253     } else {
   254         [NSOpenGLContext clearCurrentContext];
   255     }
   256 
   257     [pool release];
   258     return 0;
   259 }
   260 
   261 int
   262 Cocoa_GL_SetSwapInterval(_THIS, int interval)
   263 {
   264     NSAutoreleasePool *pool;
   265     NSOpenGLContext *nscontext;
   266     GLint value;
   267     int status;
   268 
   269     pool = [[NSAutoreleasePool alloc] init];
   270 
   271     nscontext = [NSOpenGLContext currentContext];
   272     if (nscontext != nil) {
   273         value = interval;
   274         [nscontext setValues:&value forParameter:NSOpenGLCPSwapInterval];
   275         status = 0;
   276     } else {
   277         status = SDL_SetError("No current OpenGL context");
   278     }
   279 
   280     [pool release];
   281     return status;
   282 }
   283 
   284 int
   285 Cocoa_GL_GetSwapInterval(_THIS)
   286 {
   287     NSAutoreleasePool *pool;
   288     NSOpenGLContext *nscontext;
   289     GLint value;
   290     int status = 0;
   291 
   292     pool = [[NSAutoreleasePool alloc] init];
   293 
   294     nscontext = [NSOpenGLContext currentContext];
   295     if (nscontext != nil) {
   296         [nscontext getValues:&value forParameter:NSOpenGLCPSwapInterval];
   297         status = (int)value;
   298     }
   299 
   300     [pool release];
   301     return status;
   302 }
   303 
   304 void
   305 Cocoa_GL_SwapWindow(_THIS, SDL_Window * window)
   306 {
   307     NSAutoreleasePool *pool;
   308     NSOpenGLContext *nscontext;
   309 
   310     pool = [[NSAutoreleasePool alloc] init];
   311 
   312     /* FIXME: Do we need to get the context for the window? */
   313     nscontext = [NSOpenGLContext currentContext];
   314     if (nscontext != nil) {
   315         [nscontext flushBuffer];
   316     }
   317 
   318     [pool release];
   319 }
   320 
   321 void
   322 Cocoa_GL_DeleteContext(_THIS, SDL_GLContext context)
   323 {
   324     NSAutoreleasePool *pool;
   325     NSOpenGLContext *nscontext = (NSOpenGLContext *)context;
   326 
   327     pool = [[NSAutoreleasePool alloc] init];
   328 
   329     [nscontext clearDrawable];
   330     [nscontext release];
   331 
   332     [pool release];
   333 }
   334 
   335 #endif /* SDL_VIDEO_OPENGL_CGL */
   336 
   337 /* vi: set ts=4 sw=4 expandtab: */