author Sam Lantinga <>
Sun, 07 Jul 2019 09:10:56 -0700
changeset 12928 3c4a4b1077cd
parent 11605 b914622c734e
permissions -rw-r--r--
Fixed bug 4710 - audio/alsa: avoid configuring hardware parameters with only a single period

Anthony Pesch

The previous code first configured the period size using snd_pcm_hw_par-
ams_set_period_size_near. Then, it further narrowed the configuration
space by calling snd_pcm_hw_params_set_buffer_size_near using a buffer
size of 2 times the _requested_ period size in order to try and get a
configuration with only 2 periods. If the configured period size was
larger than the requested size, the second call could inadvertently
narrow the configuration space to contain only a single period.

Rather than fixing the call to snd_pcm_hw_params_set_buffer_size_near
to use a size of 2 times the configured period size, the code has been
changed to use snd_pcm_hw_params_set_periods_min in order to more
clearly explain the intent.
     1 if (NOT EXISTS "@CMAKE_BINARY_DIR@/install_manifest.txt")
     2     message(FATAL_ERROR "Cannot find install manifest: \"@CMAKE_BINARY_DIR@/install_manifest.txt\"")
     3 endif(NOT EXISTS "@CMAKE_BINARY_DIR@/install_manifest.txt")
     5 file(READ "@CMAKE_BINARY_DIR@/install_manifest.txt" files)
     6 string(REGEX REPLACE "\n" ";" files "${files}")
     7 foreach (file ${files})
     8     message(STATUS "Uninstalling \"$ENV{DESTDIR}${file}\"")
     9     execute_process(
    10         COMMAND @CMAKE_COMMAND@ -E remove "$ENV{DESTDIR}${file}"
    11         OUTPUT_VARIABLE rm_out
    12         RESULT_VARIABLE rm_retval
    13     )
    14     if(NOT ${rm_retval} EQUAL 0)
    15         message(FATAL_ERROR "Problem when removing \"$ENV{DESTDIR}${file}\"")
    16     endif (NOT ${rm_retval} EQUAL 0)
    17 endforeach(file)