src/SDL_error_c.h
author Sam Lantinga <slouken@libsdl.org>
Thu, 16 May 2013 00:43:22 -0700
changeset 7180 3733e68edbc3
parent 6885 700f1b25f77f
child 7191 75360622e65f
permissions -rw-r--r--
Fixed bug 1846 - _allmul implementation in SDL_stdlib.c doesn't clean up the stack

Colin Barrett

I see this manifest itself (VS2012 x86) as:

"Run-Time Check Failure #0 - The value of ESP was not properly saved across a function call. This is usually a result of calling a function declared with one calling convention with a function pointer declared with a different calling convention."

in the first call to SDL_GetTicks in my application. The disassembly at the problem line is:

hires_now.QuadPart *= 1000;
00AD0792 push 0
00AD0794 push 3E8h
00AD0799 mov eax,dword ptr [ebp-10h]
00AD079C push eax
00AD079D mov ecx,dword ptr [hires_now]
00AD07A0 push ecx
00AD07A1 call _allmul (0AE7D40h)
00AD07A6 mov dword ptr [hires_now],eax
00AD07A9 mov dword ptr [ebp-10h],edx

Apparently _allmul should be popping the stack but isn't (other similar functions in SDL_stdlib.c - _alldiv and whatnot - DO pop the stack).

A 'ret 10h' at the end of _allmul appears to do the trick
     1 /*
     2   Simple DirectMedia Layer
     3   Copyright (C) 1997-2013 Sam Lantinga <slouken@libsdl.org>
     4 
     5   This software is provided 'as-is', without any express or implied
     6   warranty.  In no event will the authors be held liable for any damages
     7   arising from the use of this software.
     8 
     9   Permission is granted to anyone to use this software for any purpose,
    10   including commercial applications, and to alter it and redistribute it
    11   freely, subject to the following restrictions:
    12 
    13   1. The origin of this software must not be misrepresented; you must not
    14      claim that you wrote the original software. If you use this software
    15      in a product, an acknowledgment in the product documentation would be
    16      appreciated but is not required.
    17   2. Altered source versions must be plainly marked as such, and must not be
    18      misrepresented as being the original software.
    19   3. This notice may not be removed or altered from any source distribution.
    20 */
    21 #include "SDL_config.h"
    22 
    23 /* This file defines a structure that carries language-independent
    24    error messages
    25 */
    26 
    27 #ifndef _SDL_error_c_h
    28 #define _SDL_error_c_h
    29 
    30 #define ERR_MAX_STRLEN	128
    31 #define ERR_MAX_ARGS	5
    32 
    33 typedef struct SDL_error
    34 {
    35     /* This is a numeric value corresponding to the current error */
    36     int error;
    37 
    38     /* This is a key used to index into a language hashtable containing
    39        internationalized versions of the SDL error messages.  If the key
    40        is not in the hashtable, or no hashtable is available, the key is
    41        used directly as an error message format string.
    42      */
    43     char key[ERR_MAX_STRLEN];
    44 
    45     /* These are the arguments for the error functions */
    46     int argc;
    47     union
    48     {
    49         void *value_ptr;
    50 #if 0                           /* What is a character anyway?  (UNICODE issues) */
    51         unsigned char value_c;
    52 #endif
    53         int value_i;
    54         double value_f;
    55         char buf[ERR_MAX_STRLEN];
    56     } args[ERR_MAX_ARGS];
    57 } SDL_error;
    58 
    59 /* Defined in SDL_thread.c */
    60 extern SDL_error *SDL_GetErrBuf(void);
    61 
    62 #endif /* _SDL_error_c_h */
    63 
    64 /* vi: set ts=4 sw=4 expandtab: */