author Sam Lantinga <>
Thu, 16 May 2013 00:43:22 -0700
changeset 7180 3733e68edbc3
parent 6250 cce0ddcf6747
child 7841 b5d893a07471
permissions -rw-r--r--
Fixed bug 1846 - _allmul implementation in SDL_stdlib.c doesn't clean up the stack

Colin Barrett

I see this manifest itself (VS2012 x86) as:

"Run-Time Check Failure #0 - The value of ESP was not properly saved across a function call. This is usually a result of calling a function declared with one calling convention with a function pointer declared with a different calling convention."

in the first call to SDL_GetTicks in my application. The disassembly at the problem line is:

hires_now.QuadPart *= 1000;
00AD0792 push 0
00AD0794 push 3E8h
00AD0799 mov eax,dword ptr [ebp-10h]
00AD079C push eax
00AD079D mov ecx,dword ptr [hires_now]
00AD07A0 push ecx
00AD07A1 call _allmul (0AE7D40h)
00AD07A6 mov dword ptr [hires_now],eax
00AD07A9 mov dword ptr [ebp-10h],edx

Apparently _allmul should be popping the stack but isn't (other similar functions in SDL_stdlib.c - _alldiv and whatnot - DO pop the stack).

A 'ret 10h' at the end of _allmul appears to do the trick
     1 # sdl pkg-config source file
     3 prefix=@prefix@
     4 exec_prefix=@exec_prefix@
     5 libdir=@libdir@
     6 includedir=@includedir@
     8 Name: sdl2
     9 Description: Simple DirectMedia Layer is a cross-platform multimedia library designed to provide low level access to audio, keyboard, mouse, joystick, 3D hardware via OpenGL, and 2D video framebuffer.
    10 Version: @SDL_VERSION@
    11 Requires:
    12 Conflicts:
    13 Libs: -L${libdir} @SDL_RLD_FLAGS@ @SDL_LIBS@
    14 Libs.private: @SDL_STATIC_LIBS@
    15 Cflags: -I${includedir}/SDL2 @SDL_CFLAGS@