sdl2-config.in
author Sam Lantinga <slouken@libsdl.org>
Thu, 16 May 2013 00:43:22 -0700
changeset 7180 3733e68edbc3
parent 6250 cce0ddcf6747
child 7841 b5d893a07471
permissions -rw-r--r--
Fixed bug 1846 - _allmul implementation in SDL_stdlib.c doesn't clean up the stack

Colin Barrett

I see this manifest itself (VS2012 x86) as:

"Run-Time Check Failure #0 - The value of ESP was not properly saved across a function call. This is usually a result of calling a function declared with one calling convention with a function pointer declared with a different calling convention."

in the first call to SDL_GetTicks in my application. The disassembly at the problem line is:

hires_now.QuadPart *= 1000;
00AD0792 push 0
00AD0794 push 3E8h
00AD0799 mov eax,dword ptr [ebp-10h]
00AD079C push eax
00AD079D mov ecx,dword ptr [hires_now]
00AD07A0 push ecx
00AD07A1 call _allmul (0AE7D40h)
00AD07A6 mov dword ptr [hires_now],eax
00AD07A9 mov dword ptr [ebp-10h],edx

Apparently _allmul should be popping the stack but isn't (other similar functions in SDL_stdlib.c - _alldiv and whatnot - DO pop the stack).

A 'ret 10h' at the end of _allmul appears to do the trick
     1 #!/bin/sh
     2 
     3 prefix=@prefix@
     4 exec_prefix=@exec_prefix@
     5 exec_prefix_set=no
     6 libdir=@libdir@
     7 
     8 @ENABLE_STATIC_FALSE@usage="\
     9 @ENABLE_STATIC_FALSE@Usage: $0 [--prefix[=DIR]] [--exec-prefix[=DIR]] [--version] [--cflags] [--libs]"
    10 @ENABLE_STATIC_TRUE@usage="\
    11 @ENABLE_STATIC_TRUE@Usage: $0 [--prefix[=DIR]] [--exec-prefix[=DIR]] [--version] [--cflags] [--libs] [--static-libs]"
    12 
    13 if test $# -eq 0; then
    14       echo "${usage}" 1>&2
    15       exit 1
    16 fi
    17 
    18 while test $# -gt 0; do
    19   case "$1" in
    20   -*=*) optarg=`echo "$1" | sed 's/[-_a-zA-Z0-9]*=//'` ;;
    21   *) optarg= ;;
    22   esac
    23 
    24   case $1 in
    25     --prefix=*)
    26       prefix=$optarg
    27       if test $exec_prefix_set = no ; then
    28         exec_prefix=$optarg
    29       fi
    30       ;;
    31     --prefix)
    32       echo $prefix
    33       ;;
    34     --exec-prefix=*)
    35       exec_prefix=$optarg
    36       exec_prefix_set=yes
    37       ;;
    38     --exec-prefix)
    39       echo $exec_prefix
    40       ;;
    41     --version)
    42       echo @SDL_VERSION@
    43       ;;
    44     --cflags)
    45       echo -I@includedir@/SDL2 @SDL_CFLAGS@
    46       ;;
    47 @ENABLE_SHARED_TRUE@    --libs)
    48 @ENABLE_SHARED_TRUE@      echo -L@libdir@ @SDL_RLD_FLAGS@ @SDL_LIBS@
    49 @ENABLE_SHARED_TRUE@      ;;
    50 @ENABLE_STATIC_TRUE@@ENABLE_SHARED_TRUE@    --static-libs)
    51 @ENABLE_STATIC_TRUE@@ENABLE_SHARED_FALSE@    --libs|--static-libs)
    52 @ENABLE_STATIC_TRUE@      echo -L@libdir@ @SDL_RLD_FLAGS@ @SDL_STATIC_LIBS@
    53 @ENABLE_STATIC_TRUE@      ;;
    54     *)
    55       echo "${usage}" 1>&2
    56       exit 1
    57       ;;
    58   esac
    59   shift
    60 done