include/SDL_system.h
author Sam Lantinga <slouken@libsdl.org>
Thu, 16 May 2013 00:43:22 -0700
changeset 7180 3733e68edbc3
parent 7095 79ca4d26d4b3
child 7191 75360622e65f
permissions -rw-r--r--
Fixed bug 1846 - _allmul implementation in SDL_stdlib.c doesn't clean up the stack

Colin Barrett

I see this manifest itself (VS2012 x86) as:

"Run-Time Check Failure #0 - The value of ESP was not properly saved across a function call. This is usually a result of calling a function declared with one calling convention with a function pointer declared with a different calling convention."

in the first call to SDL_GetTicks in my application. The disassembly at the problem line is:

hires_now.QuadPart *= 1000;
00AD0792 push 0
00AD0794 push 3E8h
00AD0799 mov eax,dword ptr [ebp-10h]
00AD079C push eax
00AD079D mov ecx,dword ptr [hires_now]
00AD07A0 push ecx
00AD07A1 call _allmul (0AE7D40h)
00AD07A6 mov dword ptr [hires_now],eax
00AD07A9 mov dword ptr [ebp-10h],edx

Apparently _allmul should be popping the stack but isn't (other similar functions in SDL_stdlib.c - _alldiv and whatnot - DO pop the stack).

A 'ret 10h' at the end of _allmul appears to do the trick
     1 /*
     2   Simple DirectMedia Layer
     3   Copyright (C) 1997-2013 Sam Lantinga <slouken@libsdl.org>
     4 
     5   This software is provided 'as-is', without any express or implied
     6   warranty.  In no event will the authors be held liable for any damages
     7   arising from the use of this software.
     8 
     9   Permission is granted to anyone to use this software for any purpose,
    10   including commercial applications, and to alter it and redistribute it
    11   freely, subject to the following restrictions:
    12 
    13   1. The origin of this software must not be misrepresented; you must not
    14      claim that you wrote the original software. If you use this software
    15      in a product, an acknowledgment in the product documentation would be
    16      appreciated but is not required.
    17   2. Altered source versions must be plainly marked as such, and must not be
    18      misrepresented as being the original software.
    19   3. This notice may not be removed or altered from any source distribution.
    20 */
    21 
    22 /**
    23  *  \file SDL_system.h
    24  *  
    25  *  Include file for platform specific SDL API functions
    26  */
    27 
    28 #ifndef _SDL_system_h
    29 #define _SDL_system_h
    30 
    31 #include "SDL_stdinc.h"
    32 
    33 #if defined(__IPHONEOS__) && __IPHONEOS__
    34 #include "SDL_video.h"
    35 #include "SDL_keyboard.h"
    36 #endif
    37 
    38 #include "begin_code.h"
    39 /* Set up for C function definitions, even when using C++ */
    40 #ifdef __cplusplus
    41 /* *INDENT-OFF* */
    42 extern "C" {
    43 /* *INDENT-ON* */
    44 #endif
    45 
    46 /* Platform specific functions for iOS */
    47 #if defined(__IPHONEOS__) && __IPHONEOS__
    48 
    49 extern DECLSPEC int SDLCALL SDL_iPhoneSetAnimationCallback(SDL_Window * window, int interval, void (*callback)(void*), void *callbackParam);
    50 extern DECLSPEC void SDLCALL SDL_iPhoneSetEventPump(SDL_bool enabled);
    51 
    52 #endif /* __IPHONEOS__ */
    53 
    54 
    55 /* Platform specific functions for Android */
    56 #if defined(__ANDROID__) && __ANDROID__
    57 
    58 /* Get the JNI environment for the current thread
    59    This returns JNIEnv*, but the prototype is void* so we don't need jni.h
    60  */
    61 extern DECLSPEC void * SDLCALL SDL_AndroidGetJNIEnv();
    62 
    63 /* Get the SDL Activity object for the application
    64    This returns jobject, but the prototype is void* so we don't need jni.h
    65    The jobject returned by SDL_AndroidGetActivity is a local reference.
    66    It is the caller's responsibility to properly release it
    67    (using LocalReferenceHolder or manually with env->DeleteLocalRef)
    68  */
    69 extern DECLSPEC void * SDLCALL SDL_AndroidGetActivity();
    70 
    71 /* See the official Android developer guide for more information:
    72    http://developer.android.com/guide/topics/data/data-storage.html
    73 */
    74 #define SDL_ANDROID_EXTERNAL_STORAGE_READ   0x01
    75 #define SDL_ANDROID_EXTERNAL_STORAGE_WRITE  0x02
    76 
    77 /* Get the path used for internal storage for this application.
    78    This path is unique to your application and cannot be written to
    79    by other applications.
    80  */
    81 extern DECLSPEC const char * SDLCALL SDL_AndroidGetInternalStoragePath();
    82 
    83 /* Get the current state of external storage, a bitmask of these values:
    84     SDL_ANDROID_EXTERNAL_STORAGE_READ
    85     SDL_ANDROID_EXTERNAL_STORAGE_WRITE
    86    If external storage is currently unavailable, this will return 0.
    87 */
    88 extern DECLSPEC int SDLCALL SDL_AndroidGetExternalStorageState();
    89 
    90 /* Get the path used for external storage for this application.
    91    This path is unique to your application, but is public and can be
    92    written to by other applications.
    93  */
    94 extern DECLSPEC const char * SDLCALL SDL_AndroidGetExternalStoragePath();
    95 
    96 #endif /* __ANDROID__ */
    97 
    98 
    99 /* Ends C function definitions when using C++ */
   100 #ifdef __cplusplus
   101 /* *INDENT-OFF* */
   102 }
   103 /* *INDENT-ON* */
   104 #endif
   105 #include "close_code.h"
   106 
   107 #endif /* _SDL_system_h */
   108 
   109 /* vi: set ts=4 sw=4 expandtab: */