include/SDL_main.h
author Sam Lantinga <slouken@libsdl.org>
Thu, 16 May 2013 00:43:22 -0700
changeset 7180 3733e68edbc3
parent 6885 700f1b25f77f
child 7191 75360622e65f
child 8439 14d94a8a9fb6
permissions -rw-r--r--
Fixed bug 1846 - _allmul implementation in SDL_stdlib.c doesn't clean up the stack

Colin Barrett

I see this manifest itself (VS2012 x86) as:

"Run-Time Check Failure #0 - The value of ESP was not properly saved across a function call. This is usually a result of calling a function declared with one calling convention with a function pointer declared with a different calling convention."

in the first call to SDL_GetTicks in my application. The disassembly at the problem line is:

hires_now.QuadPart *= 1000;
00AD0792 push 0
00AD0794 push 3E8h
00AD0799 mov eax,dword ptr [ebp-10h]
00AD079C push eax
00AD079D mov ecx,dword ptr [hires_now]
00AD07A0 push ecx
00AD07A1 call _allmul (0AE7D40h)
00AD07A6 mov dword ptr [hires_now],eax
00AD07A9 mov dword ptr [ebp-10h],edx

Apparently _allmul should be popping the stack but isn't (other similar functions in SDL_stdlib.c - _alldiv and whatnot - DO pop the stack).

A 'ret 10h' at the end of _allmul appears to do the trick
     1 /*
     2   Simple DirectMedia Layer
     3   Copyright (C) 1997-2013 Sam Lantinga <slouken@libsdl.org>
     4 
     5   This software is provided 'as-is', without any express or implied
     6   warranty.  In no event will the authors be held liable for any damages
     7   arising from the use of this software.
     8 
     9   Permission is granted to anyone to use this software for any purpose,
    10   including commercial applications, and to alter it and redistribute it
    11   freely, subject to the following restrictions:
    12 
    13   1. The origin of this software must not be misrepresented; you must not
    14      claim that you wrote the original software. If you use this software
    15      in a product, an acknowledgment in the product documentation would be
    16      appreciated but is not required.
    17   2. Altered source versions must be plainly marked as such, and must not be
    18      misrepresented as being the original software.
    19   3. This notice may not be removed or altered from any source distribution.
    20 */
    21 
    22 #ifndef _SDL_main_h
    23 #define _SDL_main_h
    24 
    25 #include "SDL_stdinc.h"
    26 
    27 /**
    28  *  \file SDL_main.h
    29  *  
    30  *  Redefine main() on some platforms so that it is called by SDL.
    31  */
    32 
    33 #if defined(__WIN32__) || defined(__IPHONEOS__) || defined(__ANDROID__)
    34 #ifndef SDL_MAIN_HANDLED
    35 #define SDL_MAIN_NEEDED
    36 #endif
    37 #endif
    38 
    39 #ifdef __cplusplus
    40 #define C_LINKAGE	"C"
    41 #else
    42 #define C_LINKAGE
    43 #endif /* __cplusplus */
    44 
    45 /**
    46  *  \file SDL_main.h
    47  *
    48  *  The application's main() function must be called with C linkage,
    49  *  and should be declared like this:
    50  *  \code
    51  *  #ifdef __cplusplus
    52  *  extern "C"
    53  *  #endif
    54  *  int main(int argc, char *argv[])
    55  *  {
    56  *  }
    57  *  \endcode
    58  */
    59 
    60 #ifdef SDL_MAIN_NEEDED
    61 #define main	SDL_main
    62 #endif
    63 
    64 /**
    65  *  The prototype for the application's main() function
    66  */
    67 extern C_LINKAGE int SDL_main(int argc, char *argv[]);
    68 
    69 
    70 #include "begin_code.h"
    71 #ifdef __cplusplus
    72 /* *INDENT-OFF* */
    73 extern "C" {
    74 /* *INDENT-ON* */
    75 #endif
    76 
    77 #ifdef __WIN32__
    78 
    79 /**
    80  *  This can be called to set the application class at startup
    81  */
    82 extern DECLSPEC int SDLCALL SDL_RegisterApp(char *name, Uint32 style,
    83                                             void *hInst);
    84 extern DECLSPEC void SDLCALL SDL_UnregisterApp(void);
    85 
    86 #endif /* __WIN32__ */
    87 
    88 
    89 #ifdef __cplusplus
    90 /* *INDENT-OFF* */
    91 }
    92 /* *INDENT-ON* */
    93 #endif
    94 #include "close_code.h"
    95 
    96 #endif /* _SDL_main_h */
    97 
    98 /* vi: set ts=4 sw=4 expandtab: */