include/SDL_cpuinfo.h
author Sam Lantinga <slouken@libsdl.org>
Thu, 16 May 2013 00:43:22 -0700
changeset 7180 3733e68edbc3
parent 6885 700f1b25f77f
child 7191 75360622e65f
child 8439 14d94a8a9fb6
permissions -rw-r--r--
Fixed bug 1846 - _allmul implementation in SDL_stdlib.c doesn't clean up the stack

Colin Barrett

I see this manifest itself (VS2012 x86) as:

"Run-Time Check Failure #0 - The value of ESP was not properly saved across a function call. This is usually a result of calling a function declared with one calling convention with a function pointer declared with a different calling convention."

in the first call to SDL_GetTicks in my application. The disassembly at the problem line is:

hires_now.QuadPart *= 1000;
00AD0792 push 0
00AD0794 push 3E8h
00AD0799 mov eax,dword ptr [ebp-10h]
00AD079C push eax
00AD079D mov ecx,dword ptr [hires_now]
00AD07A0 push ecx
00AD07A1 call _allmul (0AE7D40h)
00AD07A6 mov dword ptr [hires_now],eax
00AD07A9 mov dword ptr [ebp-10h],edx

Apparently _allmul should be popping the stack but isn't (other similar functions in SDL_stdlib.c - _alldiv and whatnot - DO pop the stack).

A 'ret 10h' at the end of _allmul appears to do the trick
     1 /*
     2   Simple DirectMedia Layer
     3   Copyright (C) 1997-2013 Sam Lantinga <slouken@libsdl.org>
     4 
     5   This software is provided 'as-is', without any express or implied
     6   warranty.  In no event will the authors be held liable for any damages
     7   arising from the use of this software.
     8 
     9   Permission is granted to anyone to use this software for any purpose,
    10   including commercial applications, and to alter it and redistribute it
    11   freely, subject to the following restrictions:
    12 
    13   1. The origin of this software must not be misrepresented; you must not
    14      claim that you wrote the original software. If you use this software
    15      in a product, an acknowledgment in the product documentation would be
    16      appreciated but is not required.
    17   2. Altered source versions must be plainly marked as such, and must not be
    18      misrepresented as being the original software.
    19   3. This notice may not be removed or altered from any source distribution.
    20 */
    21 
    22 /**
    23  *  \file SDL_cpuinfo.h
    24  *  
    25  *  CPU feature detection for SDL.
    26  */
    27 
    28 #ifndef _SDL_cpuinfo_h
    29 #define _SDL_cpuinfo_h
    30 
    31 #include "SDL_stdinc.h"
    32 
    33 /* Need to do this here because intrin.h has C++ code in it */
    34 /* Visual Studio 2005 has a bug where intrin.h conflicts with winnt.h */
    35 #if defined(_MSC_VER) && (_MSC_VER >= 1500)
    36 #include <intrin.h>
    37 #ifndef _WIN64
    38 #define __MMX__
    39 #define __3dNOW__
    40 #endif
    41 #define __SSE__
    42 #define __SSE2__
    43 #elif defined(__MINGW64_VERSION_MAJOR)
    44 #include <intrin.h>
    45 #else
    46 #ifdef __ALTIVEC__
    47 #if HAVE_ALTIVEC_H && !defined(__APPLE_ALTIVEC__)
    48 #include <altivec.h>
    49 #undef pixel
    50 #endif
    51 #endif
    52 #ifdef __MMX__
    53 #include <mmintrin.h>
    54 #endif
    55 #ifdef __3dNOW__
    56 #include <mm3dnow.h>
    57 #endif
    58 #ifdef __SSE__
    59 #include <xmmintrin.h>
    60 #endif
    61 #ifdef __SSE2__
    62 #include <emmintrin.h>
    63 #endif
    64 #endif
    65 
    66 #include "begin_code.h"
    67 /* Set up for C function definitions, even when using C++ */
    68 #ifdef __cplusplus
    69 /* *INDENT-OFF* */
    70 extern "C" {
    71 /* *INDENT-ON* */
    72 #endif
    73 
    74 /* This is a guess for the cacheline size used for padding.
    75  * Most x86 processors have a 64 byte cache line.
    76  * The 64-bit PowerPC processors have a 128 byte cache line.
    77  * We'll use the larger value to be generally safe.
    78  */
    79 #define SDL_CACHELINE_SIZE  128
    80 
    81 /**
    82  *  This function returns the number of CPU cores available.
    83  */
    84 extern DECLSPEC int SDLCALL SDL_GetCPUCount(void);
    85 
    86 /**
    87  *  This function returns the L1 cache line size of the CPU
    88  *
    89  *  This is useful for determining multi-threaded structure padding
    90  *  or SIMD prefetch sizes.
    91  */
    92 extern DECLSPEC int SDLCALL SDL_GetCPUCacheLineSize(void);
    93 
    94 /**
    95  *  This function returns true if the CPU has the RDTSC instruction.
    96  */
    97 extern DECLSPEC SDL_bool SDLCALL SDL_HasRDTSC(void);
    98 
    99 /**
   100  *  This function returns true if the CPU has AltiVec features.
   101  */
   102 extern DECLSPEC SDL_bool SDLCALL SDL_HasAltiVec(void);
   103 
   104 /**
   105  *  This function returns true if the CPU has MMX features.
   106  */
   107 extern DECLSPEC SDL_bool SDLCALL SDL_HasMMX(void);
   108 
   109 /**
   110  *  This function returns true if the CPU has 3DNow! features.
   111  */
   112 extern DECLSPEC SDL_bool SDLCALL SDL_Has3DNow(void);
   113 
   114 /**
   115  *  This function returns true if the CPU has SSE features.
   116  */
   117 extern DECLSPEC SDL_bool SDLCALL SDL_HasSSE(void);
   118 
   119 /**
   120  *  This function returns true if the CPU has SSE2 features.
   121  */
   122 extern DECLSPEC SDL_bool SDLCALL SDL_HasSSE2(void);
   123 
   124 /**
   125  *  This function returns true if the CPU has SSE3 features.
   126  */
   127 extern DECLSPEC SDL_bool SDLCALL SDL_HasSSE3(void);
   128 
   129 /**
   130  *  This function returns true if the CPU has SSE4.1 features.
   131  */
   132 extern DECLSPEC SDL_bool SDLCALL SDL_HasSSE41(void);
   133 
   134 /**
   135  *  This function returns true if the CPU has SSE4.2 features.
   136  */
   137 extern DECLSPEC SDL_bool SDLCALL SDL_HasSSE42(void);
   138 
   139 
   140 /* Ends C function definitions when using C++ */
   141 #ifdef __cplusplus
   142 /* *INDENT-OFF* */
   143 }
   144 /* *INDENT-ON* */
   145 #endif
   146 #include "close_code.h"
   147 
   148 #endif /* _SDL_cpuinfo_h */
   149 
   150 /* vi: set ts=4 sw=4 expandtab: */