include/SDL_config_wiz.h
author Sam Lantinga <slouken@libsdl.org>
Thu, 16 May 2013 00:43:22 -0700
changeset 7180 3733e68edbc3
parent 6885 700f1b25f77f
child 7191 75360622e65f
permissions -rw-r--r--
Fixed bug 1846 - _allmul implementation in SDL_stdlib.c doesn't clean up the stack

Colin Barrett

I see this manifest itself (VS2012 x86) as:

"Run-Time Check Failure #0 - The value of ESP was not properly saved across a function call. This is usually a result of calling a function declared with one calling convention with a function pointer declared with a different calling convention."

in the first call to SDL_GetTicks in my application. The disassembly at the problem line is:

hires_now.QuadPart *= 1000;
00AD0792 push 0
00AD0794 push 3E8h
00AD0799 mov eax,dword ptr [ebp-10h]
00AD079C push eax
00AD079D mov ecx,dword ptr [hires_now]
00AD07A0 push ecx
00AD07A1 call _allmul (0AE7D40h)
00AD07A6 mov dword ptr [hires_now],eax
00AD07A9 mov dword ptr [ebp-10h],edx

Apparently _allmul should be popping the stack but isn't (other similar functions in SDL_stdlib.c - _alldiv and whatnot - DO pop the stack).

A 'ret 10h' at the end of _allmul appears to do the trick
     1 /*
     2   Simple DirectMedia Layer
     3   Copyright (C) 1997-2013 Sam Lantinga <slouken@libsdl.org>
     4 
     5   This software is provided 'as-is', without any express or implied
     6   warranty.  In no event will the authors be held liable for any damages
     7   arising from the use of this software.
     8 
     9   Permission is granted to anyone to use this software for any purpose,
    10   including commercial applications, and to alter it and redistribute it
    11   freely, subject to the following restrictions:
    12 
    13   1. The origin of this software must not be misrepresented; you must not
    14      claim that you wrote the original software. If you use this software
    15      in a product, an acknowledgment in the product documentation would be
    16      appreciated but is not required.
    17   2. Altered source versions must be plainly marked as such, and must not be
    18      misrepresented as being the original software.
    19   3. This notice may not be removed or altered from any source distribution.
    20 */
    21 
    22 #ifndef _SDL_config_h
    23 #define _SDL_config_h
    24 
    25 /* This is a set of defines to configure the SDL features */
    26 
    27 /* General platform specific identifiers */
    28 #include "SDL_platform.h"
    29 
    30 #define SDL_BYTEORDER 1234
    31 
    32 #define HAVE_ALLOCA_H 1
    33 #define HAVE_SYS_TYPES_H 1
    34 #define HAVE_STDIO_H 1
    35 #define STDC_HEADERS 1
    36 #define HAVE_STDLIB_H 1
    37 #define HAVE_STDARG_H 1
    38 #define HAVE_MALLOC_H 1
    39 #define HAVE_MEMORY_H 1
    40 #define HAVE_STRING_H 1
    41 #define HAVE_STRINGS_H 1
    42 #define HAVE_INTTYPES_H 1
    43 #define HAVE_STDINT_H 1
    44 #define HAVE_CTYPE_H 1
    45 #define HAVE_MATH_H 1
    46 #define HAVE_ICONV_H 1
    47 #define HAVE_SIGNAL_H 1
    48 #define HAVE_MALLOC 1
    49 #define HAVE_CALLOC 1
    50 #define HAVE_REALLOC 1
    51 #define HAVE_FREE 1
    52 #define HAVE_ALLOCA 1
    53 #define HAVE_GETENV 1
    54 #define HAVE_SETENV	1
    55 #define HAVE_PUTENV 1
    56 #define HAVE_UNSETENV 1
    57 #define HAVE_QSORT 1
    58 #define HAVE_ABS 1
    59 #define HAVE_BCOPY 1
    60 #define HAVE_MEMSET 1
    61 #define HAVE_MEMCPY 1
    62 #define HAVE_MEMMOVE 1
    63 #define HAVE_STRLEN 1
    64 #define HAVE_STRDUP 1
    65 #define HAVE_STRCHR 1
    66 #define HAVE_STRRCHR 1
    67 #define HAVE_STRSTR 1
    68 #define HAVE_STRTOL 1
    69 #define HAVE_STRTOUL 1
    70 #define HAVE_STRTOLL 1
    71 #define HAVE_STRTOULL 1
    72 #define HAVE_ATOI 1
    73 #define HAVE_ATOF 1
    74 #define HAVE_STRCMP 1
    75 #define HAVE_STRNCMP 1
    76 #define HAVE_STRCASECMP 1
    77 #define HAVE_STRNCASECMP 1
    78 #define HAVE_SSCANF 1
    79 #define HAVE_SNPRINTF 1
    80 #define HAVE_VSNPRINTF 1
    81 #define HAVE_M_PI 1
    82 #define HAVE_CEIL 1
    83 #define HAVE_COPYSIGN 1
    84 #define HAVE_COS 1
    85 #define HAVE_COSF 1
    86 #define HAVE_FABS 1
    87 #define HAVE_FLOOR 1
    88 #define HAVE_LOG 1
    89 #define HAVE_SCALBN 1
    90 #define HAVE_SIN 1
    91 #define HAVE_SINF 1
    92 #define HAVE_SQRT 1
    93 #define HAVE_SIGACTION 1
    94 #define HAVE_SETJMP 1
    95 #define HAVE_NANOSLEEP 1
    96 #define HAVE_POW 1
    97 
    98 #define SDL_CDROM_DISABLED 1
    99 #define SDL_AUDIO_DRIVER_DUMMY 1
   100 #define SDL_AUDIO_DRIVER_OSS 1
   101 
   102 #define SDL_INPUT_LINUXEV 1
   103 #define SDL_INPUT_TSLIB 1
   104 #define SDL_JOYSTICK_LINUX 1
   105 #define SDL_HAPTIC_LINUX 1
   106 
   107 #define SDL_LOADSO_DLOPEN 1
   108 
   109 #define SDL_THREAD_PTHREAD 1
   110 #define SDL_THREAD_PTHREAD_RECURSIVE_MUTEX_NP 1
   111 
   112 #define SDL_TIMER_UNIX 1
   113 
   114 #define SDL_VIDEO_DRIVER_DUMMY 1
   115 #define SDL_VIDEO_DRIVER_PANDORA 1
   116 #define SDL_VIDEO_RENDER_OGL_ES 1
   117 #define SDL_VIDEO_OPENGL_ES 1
   118 
   119 #endif /* _SDL_config_h */