author Sam Lantinga <>
Thu, 16 May 2013 00:43:22 -0700
changeset 7180 3733e68edbc3
parent 2819 222aa027e650
child 7229 2636ad0a52e4
permissions -rw-r--r--
Fixed bug 1846 - _allmul implementation in SDL_stdlib.c doesn't clean up the stack

Colin Barrett

I see this manifest itself (VS2012 x86) as:

"Run-Time Check Failure #0 - The value of ESP was not properly saved across a function call. This is usually a result of calling a function declared with one calling convention with a function pointer declared with a different calling convention."

in the first call to SDL_GetTicks in my application. The disassembly at the problem line is:

hires_now.QuadPart *= 1000;
00AD0792 push 0
00AD0794 push 3E8h
00AD0799 mov eax,dword ptr [ebp-10h]
00AD079C push eax
00AD079D mov ecx,dword ptr [hires_now]
00AD07A0 push ecx
00AD07A1 call _allmul (0AE7D40h)
00AD07A6 mov dword ptr [hires_now],eax
00AD07A9 mov dword ptr [ebp-10h],edx

Apparently _allmul should be popping the stack but isn't (other similar functions in SDL_stdlib.c - _alldiv and whatnot - DO pop the stack).

A 'ret 10h' at the end of _allmul appears to do the trick
     1 <HTML>
     2 	<HEAD>
     3 		<TITLE>Using SDL with Microsoft Visual C++</TITLE>
     4 	</HEAD>
     5 	<BODY>
     6 		<H1>
     7 			Using SDL with Microsoft Visual C++ 5,6&nbsp;and 7
     8 		</H1>
     9 		<H3>
    10 			by <A HREF="">Lion Kimbro </A>and additions by <A HREF="">
    11 				James Turk</A>
    12 		</H3>
    13 		<p>
    14 			You can either use the precompiled libraries from <A HREF="">
    15 				the SDL Download web site </A>, or you can build SDL yourself.
    16 		</p>
    17 		<H3>
    18 			Building SDL
    19 		</H3>
    20 		<P>
    21 			Go into the VisualC directory and double-click on the VC++ file "<CODE>SDL.dsw</CODE>" <STRONG><FONT color="#009900">("<CODE>SDL.sln</CODE>")</FONT></STRONG>. This should open up the IDE.
    22 		</P>
    23 		<P>
    24 			You may be prompted at this point to upgrade the workspace, should you be using 
    25 			a more recent version of Visual C++. If so, allow the workspace to be upgraded.
    26 		</P>
    27 		<P>
    28 			Build the <CODE>.dll</CODE> and <CODE>.lib</CODE> files.
    29 		</P>
    30 		<P>
    31 			This is done by right clicking on each project in turn (Projects are listed in 
    32 			the Workspace panel in the FileView tab), and selecting "Build".
    33 		</P>
    34 		<P>
    35 			If you get an error about SDL_config.h being missing, you should
    36 			copy include/SDL_config.h.default to include/SDL_config.h and try again.
    37 		</P>
    38 		<P>
    39 			You may get a few warnings, but you should not get any errors. You do have to 
    40 			have at least the DirectX 5 SDK installed, however. The latest 
    41 			version of DirectX can be downloaded or purchased on a cheap CD (my 
    42 			recommendation) from <A HREF="">Microsoft </A>.
    43 		</P>
    44 		<P>
    45 			Later, we will refer to the following .lib and .dll files that have just been 
    46 			generated:
    47 		</P>
    48 		<ul>
    49     <li> SDL.dll</li>
    50     <li> SDL.lib</li>
    51     <li> SDLmain.lib</li>
    52     </ul>
    53 		<P>
    54 			Search for these using the Windows Find (Windows-F) utility, if you don't 
    55 			already know where they should be. For those of you with a clue, look inside 
    56 			the Debug or Release directories of the subdirectories of the Project folder. 
    57 			(It might be easier to just use Windows Find if this sounds confusing. And 
    58 			don't worry about needing a clue; we all need visits from the clue fairy 
    59 			frequently.)
    60 		</P>
    61 		<H3>
    62 			Creating a Project with SDL
    63 		</H3>
    64 		<P>
    65 			Create a project as a Win32 Application.
    66 		</P>
    67 		<P>
    68 			Create a C++ file for your project.
    69 		</P>
    70 		<P>
    71 			Set the C runtime to "Multi-threaded DLL" in the menu: <CODE>Project|Settings|C/C++ 
    72 				tab|Code Generation|Runtime Library </CODE>.
    73 		</P>
    74 		<P>
    75 			Add the SDL <CODE>include</CODE> directory to your list of includes in the 
    76 			menu: <CODE>Project|Settings|C/C++ tab|Preprocessor|Additional include directories </CODE>
    77 			.
    78 			<br>
    79 			<STRONG><FONT color="#009900">VC7 Specific: Instead of doing this I find it easier to 
    80 					add the include and library directories to the list that VC7 keeps. Do this by 
    81 					selecting Tools|Options|Projects|VC++ Directories and under the "Show 
    82 					Directories For:" dropbox select "Include Files", and click the "New Directory 
    83 					Icon" and add the [SDLROOT]\include directory (ex. If you installed to 
    84 					c:\SDL-1.2.5\ add c:\SDL-1.2.5\include).&nbsp;Proceed to&nbsp;change the 
    85 					dropbox selection to "Library Files" and add [SDLROOT]\lib.</FONT></STRONG>
    86 		</P>
    87 			<P>
    88 				The "include directory" I am referring to is the <CODE>include</CODE> folder 
    89 				within the main SDL directory (the one that this HTML file located within).
    90 			</P>
    91 			<P>
    92 				Now we're going to use the files that we had created earlier in the Build SDL 
    93 				step.
    94 			</P>
    95 			<P>
    96 				Copy the following files into your Project directory:
    97 			</P>
    98 			<ul>
    99      <li> SDL.dll</li>
   100      </ul>
   101 			<P>
   102 				Add the following files to your project (It is not necessary to copy them to 
   103 				your project directory):
   104 			</P>
   105 			<ul>
   106      <li> SDL.lib </li>
   107      <li> SDLmain.lib</li>
   108      </ul>
   109 			<P>
   110 				(To add them to your project, right click on your project, and select "Add 
   111 				files to project")
   112 			</P>
   113 		<P><STRONG><FONT color="#009900">Instead of adding the files to your project it is more 
   114 					desireable to add them to the linker options: Project|Properties|Linker|Command 
   115 					Line and type the names of the libraries to link with in the "Additional 
   116 					Options:" box.&nbsp; Note: This must be done&nbsp;for&nbsp;each&nbsp;build 
   117 					configuration (eg. Release,Debug).</FONT></STRONG></P>
   118 		<H3>
   119 			SDL 101, First Day of Class
   120 		</H3>
   121 		<P>
   122 			Now create the basic body of your project. The body of your program should take 
   123 			the following form: <CODE>
   124 				<PRE>
   125 #include "SDL.h"
   127 int main( int argc, char* argv[] )
   128 {
   129   // Body of the program goes here.
   130   return 0;
   131 }
   132 </PRE>
   133 			</CODE>
   134 		<P></P>
   135 		<H3>
   136 			That's it!
   137 		</H3>
   138 		<P>
   139 			I hope that this document has helped you get through the most difficult part of 
   140 			using the SDL: installing it. Suggestions for improvements to this document 
   141 			should be sent to the writers of this document.
   142 		</P>
   143 		<P>
   144 			Thanks to Paulus Esterhazy (, for the work on VC++ port.
   145 		</P>
   146 		<P>
   147 			This document was originally called "VisualC.txt", and was written by <A HREF="">
   148 				Sam Lantinga</A>.
   149 		</P>
   150 		<P>
   151 			Later, it was converted to HTML and expanded into the document that you see 
   152 			today by <A HREF="">Lion Kimbro</A>.
   153 		</P>
   154 		<P>Minor Fixes and Visual C++ 7 Information (In Green) was added by <A HREF="">James Turk</A>
   155 		</P>
   156 	</BODY>
   157 </HTML>