README.Platforms
author Sam Lantinga <slouken@libsdl.org>
Thu, 16 May 2013 00:43:22 -0700
changeset 7180 3733e68edbc3
parent 7031 3242aa26100f
permissions -rw-r--r--
Fixed bug 1846 - _allmul implementation in SDL_stdlib.c doesn't clean up the stack

Colin Barrett

I see this manifest itself (VS2012 x86) as:

"Run-Time Check Failure #0 - The value of ESP was not properly saved across a function call. This is usually a result of calling a function declared with one calling convention with a function pointer declared with a different calling convention."

in the first call to SDL_GetTicks in my application. The disassembly at the problem line is:

hires_now.QuadPart *= 1000;
00AD0792 push 0
00AD0794 push 3E8h
00AD0799 mov eax,dword ptr [ebp-10h]
00AD079C push eax
00AD079D mov ecx,dword ptr [hires_now]
00AD07A0 push ecx
00AD07A1 call _allmul (0AE7D40h)
00AD07A6 mov dword ptr [hires_now],eax
00AD07A9 mov dword ptr [ebp-10h],edx

Apparently _allmul should be popping the stack but isn't (other similar functions in SDL_stdlib.c - _alldiv and whatnot - DO pop the stack).

A 'ret 10h' at the end of _allmul appears to do the trick
     1 
     2 This is a list of the platforms SDL supports, and who maintains them.
     3 
     4 Officially supported platforms
     5 ==============================
     6 (code compiles, and thoroughly tested for release)
     7 ==============================
     8 Windows XP
     9 Windows Vista
    10 Windows 7
    11 Mac OS X 10.4+
    12 Linux 2.6+
    13 iOS 3.1.3+
    14 Android 2.3.3+
    15 
    16 Unofficially supported platforms
    17 ================================
    18 (code compiles, but not thoroughly tested)
    19 ================================
    20 FreeBSD
    21 NetBSD
    22 OpenBSD
    23 Solaris
    24 
    25 Platforms supported by volunteers
    26 =================================
    27 Haiku - maintained by Axel Dörfler <axeld@pinc-software.de>
    28 PSP - maintained by 527721088@qq.com
    29 Pandora - maintained by Scott Smith <pickle136@sbcglobal.net>
    30 
    31 Platforms that need maintainers
    32 ===============================