Makefile.pandora
author Sam Lantinga <slouken@libsdl.org>
Thu, 16 May 2013 00:43:22 -0700
changeset 7180 3733e68edbc3
parent 5586 7fe92c1dc1d9
child 7667 be1cc6f55840
permissions -rw-r--r--
Fixed bug 1846 - _allmul implementation in SDL_stdlib.c doesn't clean up the stack

Colin Barrett

I see this manifest itself (VS2012 x86) as:

"Run-Time Check Failure #0 - The value of ESP was not properly saved across a function call. This is usually a result of calling a function declared with one calling convention with a function pointer declared with a different calling convention."

in the first call to SDL_GetTicks in my application. The disassembly at the problem line is:

hires_now.QuadPart *= 1000;
00AD0792 push 0
00AD0794 push 3E8h
00AD0799 mov eax,dword ptr [ebp-10h]
00AD079C push eax
00AD079D mov ecx,dword ptr [hires_now]
00AD07A0 push ecx
00AD07A1 call _allmul (0AE7D40h)
00AD07A6 mov dword ptr [hires_now],eax
00AD07A9 mov dword ptr [ebp-10h],edx

Apparently _allmul should be popping the stack but isn't (other similar functions in SDL_stdlib.c - _alldiv and whatnot - DO pop the stack).

A 'ret 10h' at the end of _allmul appears to do the trick
     1 # Makefile to build the pandora SDL library
     2 
     3 AR	= arm-none-linux-gnueabi-ar
     4 RANLIB	= arm-none-linux-gnueabi-ranlib
     5 CC = arm-none-linux-gnueabi-gcc
     6 CXX = arm-none-linux-gnueabi-g++
     7 STRIP = arm-none-linux-gnueabi-strip
     8 
     9 CFLAGS  = -O3 -march=armv7-a -mcpu=cortex-a8 -mtune=cortex-a8 -mfloat-abi=softfp \
    10 	-mfpu=neon -ftree-vectorize -ffast-math -fomit-frame-pointer -fno-strict-aliasing -fsingle-precision-constant \
    11 	-I./include -I$(PNDSDK)/usr/include -DSDL_REVISION=0
    12 
    13 TARGET  = libSDL.a
    14 
    15 SOURCES = ./src/*.c ./src/audio/*.c ./src/cpuinfo/*.c ./src/events/*.c \
    16 	./src/file/*.c ./src/stdlib/*.c ./src/thread/*.c ./src/timer/*.c ./src/video/*.c \
    17 	./src/joystick/*.c ./src/haptic/*.c ./src/power/*.c ./src/video/dummy/*.c ./src/audio/disk/*.c \
    18 	./src/audio/dummy/*.c ./src/loadso/dlopen/*.c ./src/audio/dsp/*.c \
    19 	./src/thread/pthread/SDL_systhread.c ./src/thread/pthread/SDL_syssem.c \
    20 	./src/thread/pthread/SDL_sysmutex.c ./src/thread/pthread/SDL_syscond.c \
    21 	./src/joystick/linux/*.c ./src/haptic/linux/*.c ./src/timer/unix/*.c \
    22 	./src/atomic/linux/*.c \
    23 	./src/video/pandora/SDL_pandora.o ./src/video/pandora/SDL_pandora_events.o ./src/video/x11/*.c 
    24 	
    25 
    26 OBJECTS = $(shell echo $(SOURCES) | sed -e 's,\.c,\.o,g')
    27 
    28 CONFIG_H = $(shell cp include/SDL_config_pandora.h include/SDL_config.h && touch include/SDL_revision.h)
    29 
    30 all: $(TARGET)
    31 
    32 $(TARGET): $(CONFIG_H) $(OBJECTS)
    33 	$(AR) crv $@ $^
    34 	$(RANLIB) $@
    35 
    36 clean:
    37 	rm -f $(TARGET) $(OBJECTS)