Makefile.minimal
author Sam Lantinga <slouken@libsdl.org>
Thu, 16 May 2013 00:43:22 -0700
changeset 7180 3733e68edbc3
parent 5310 a9945ce48999
child 7667 be1cc6f55840
permissions -rw-r--r--
Fixed bug 1846 - _allmul implementation in SDL_stdlib.c doesn't clean up the stack

Colin Barrett

I see this manifest itself (VS2012 x86) as:

"Run-Time Check Failure #0 - The value of ESP was not properly saved across a function call. This is usually a result of calling a function declared with one calling convention with a function pointer declared with a different calling convention."

in the first call to SDL_GetTicks in my application. The disassembly at the problem line is:

hires_now.QuadPart *= 1000;
00AD0792 push 0
00AD0794 push 3E8h
00AD0799 mov eax,dword ptr [ebp-10h]
00AD079C push eax
00AD079D mov ecx,dword ptr [hires_now]
00AD07A0 push ecx
00AD07A1 call _allmul (0AE7D40h)
00AD07A6 mov dword ptr [hires_now],eax
00AD07A9 mov dword ptr [ebp-10h],edx

Apparently _allmul should be popping the stack but isn't (other similar functions in SDL_stdlib.c - _alldiv and whatnot - DO pop the stack).

A 'ret 10h' at the end of _allmul appears to do the trick
     1 # Makefile to build the SDL library
     2 
     3 INCLUDE = -I./include
     4 CFLAGS  = -g -O2 $(INCLUDE)
     5 AR	= ar
     6 RANLIB	= ranlib
     7 
     8 TARGET  = libSDL.a
     9 SOURCES = \
    10 	src/*.c \
    11 	src/audio/*.c \
    12 	src/audio/dummy/*.c \
    13 	src/cpuinfo/*.c \
    14 	src/events/*.c \
    15 	src/file/*.c \
    16 	src/haptic/*.c \
    17 	src/haptic/dummy/*.c \
    18 	src/joystick/*.c \
    19 	src/joystick/dummy/*.c \
    20 	src/loadso/dummy/*.c \
    21 	src/power/*.c \
    22 	src/render/*.c \
    23 	src/render/software/*.c \
    24 	src/stdlib/*.c \
    25 	src/thread/*.c \
    26 	src/thread/generic/*.c \
    27 	src/timer/*.c \
    28 	src/timer/dummy/*.c \
    29 	src/video/*.c \
    30 	src/video/dummy/*.c \
    31 
    32 OBJECTS = $(shell echo $(SOURCES) | sed -e 's,\.c,\.o,g')
    33 
    34 all: $(TARGET)
    35 
    36 $(TARGET): $(OBJECTS)
    37 	$(AR) crv $@ $^
    38 	$(RANLIB) $@
    39 
    40 clean:
    41 	rm -f $(TARGET) $(OBJECTS)